Skip to content

fix: default create-action URL getting targeted when model doesn't match #18802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danharrin merged 2 commits into from
Dec 30, 2025
Merged

fix: default create-action URL getting targeted when model doesn't match #18802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
760182f
Fix create action getting targeted to wrong page
ralphjsmit Dec 30, 2025
3a5af31
WIP
ralphjsmit Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/panels/src/Resources/Pages/ManageRelatedRecords.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,23 +300,28 @@ public function getDefaultActionUrl(Action $action): ?string
return null;
}

$actionModel = $action->getModel();

if (
($action instanceof CreateAction) &&
($relatedResource::hasPage('create'))
($relatedResource::hasPage('create')) &&
(blank($actionModel) || ($actionModel === $relatedResource::getModel()))
) {
return $relatedResource::getUrl('create', shouldGuessMissingParameters: true);
}

if (
($action instanceof EditAction) &&
($relatedResource::hasPage('edit'))
($relatedResource::hasPage('edit')) &&
(blank($actionModel) || ($actionModel === $relatedResource::getModel()))
) {
return $relatedResource::getUrl('edit', ['record' => $action->getRecord()], shouldGuessMissingParameters: true);
}

if (
($action instanceof ViewAction) &&
($relatedResource::hasPage('view'))
($relatedResource::hasPage('view')) &&
(blank($actionModel) || ($actionModel === $relatedResource::getModel()))
) {
return $relatedResource::getUrl('view', ['record' => $action->getRecord()], shouldGuessMissingParameters: true);
}
Expand Down
11 changes: 8 additions & 3 deletions packages/panels/src/Resources/Pages/Page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,25 +349,30 @@ public function getDefaultActionRelationship(Action $action): ?Relation

public function getDefaultActionUrl(Action $action): ?string
{
$actionModel = $action->getModel();

if (
($action instanceof CreateAction) &&
(static::getResource()::hasPage('create'))
(static::getResource()::hasPage('create')) &&
(blank($actionModel) || ($actionModel === static::getResource()::getModel()))
) {
return $this->getResourceUrl('create');
}

if (
($action instanceof EditAction) &&
(static::getResource()::hasPage('edit')) &&
(! $this instanceof EditRecord)
(! $this instanceof EditRecord) &&
(blank($actionModel) || ($actionModel === static::getResource()::getModel()))
) {
return $this->getResourceUrl('edit', ['record' => $action->getRecord()]);
}

if (
($action instanceof ViewAction) &&
(static::getResource()::hasPage('view')) &&
(! $this instanceof ViewRecord)
(! $this instanceof ViewRecord) &&
(blank($actionModel) || ($actionModel === static::getResource()::getModel()))
) {
return $this->getResourceUrl('view', ['record' => $action->getRecord()]);
}
Expand Down
11 changes: 8 additions & 3 deletions packages/panels/src/Resources/RelationManagers/RelationManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,23 +377,28 @@ public function getDefaultActionUrl(Action $action): ?string
return null;
}

$actionModel = $action->getModel();

if (
($action instanceof CreateAction) &&
($relatedResource::hasPage('create'))
($relatedResource::hasPage('create')) &&
(blank($actionModel) || ($actionModel === $relatedResource::getModel()))
) {
return $relatedResource::getUrl('create', shouldGuessMissingParameters: true);
}

if (
($action instanceof EditAction) &&
($relatedResource::hasPage('edit'))
($relatedResource::hasPage('edit')) &&
(blank($actionModel) || ($actionModel === $relatedResource::getModel()))
) {
return $relatedResource::getUrl('edit', ['record' => $action->getRecord()], shouldGuessMissingParameters: true);
}

if (
($action instanceof ViewAction) &&
($relatedResource::hasPage('view'))
($relatedResource::hasPage('view')) &&
(blank($actionModel) || ($actionModel === $relatedResource::getModel()))
) {
return $relatedResource::getUrl('view', ['record' => $action->getRecord()], shouldGuessMissingParameters: true);
}
Expand Down
Loading