[4.x] fix - handle Htmlable state in TextEntry/TextColumn toEmbeddedHtml blank check #18899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When rendering the content of a
Filament\Forms\Components\RichEditorfield using aFilament\Infolists\Components\TextEntrywhen the model is set up with theFilament\Forms\Components\RichEditor\Models\Contracts\HasRichContentcontract andFilament\Forms\Components\RichEditor\Models\Concerns\InteractsWithRichContenttrait, the placeholder is never rendered.This is because the
blank($state)check does return false because it is given aFilament\Forms\Components\RichEditor\RichContentAttribute.This fix checks if the
$stateimplementsIlluminate\Contracts\Support\Htmlableand uses the rendered html in the blank check instead.This fixes both
NULLandEMPTYvalues.Functional changes
composer cscommand.