Skip to content

fix: actionJs serialization in notification actions#19199

Merged
danharrin merged 4 commits intofilamentphp:4.xfrom
People-Sea:fix/issues/19196
Feb 4, 2026
Merged

fix: actionJs serialization in notification actions#19199
danharrin merged 4 commits intofilamentphp:4.xfrom
People-Sea:fix/issues/19196

Conversation

@People-Sea
Copy link
Contributor

@People-Sea People-Sea commented Feb 4, 2026

Description

Fixes #19196

actionJs() / alpineClickHandler() was not being serialized in Action::toArray(), causing notification actions to trigger Livewire requests instead of executing client-side JS.

Added alpineClickHandler to serialization/deserialization in toArray() and fromArray().

Visual changes

Before

before.mov

After

after.mov

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@People-Sea People-Sea marked this pull request as ready for review February 4, 2026 09:12
@danharrin danharrin added the bug Something isn't working label Feb 4, 2026
@danharrin danharrin added this to the v4 milestone Feb 4, 2026
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Roadmap Feb 4, 2026
@danharrin danharrin merged commit b0de8ef into filamentphp:4.x Feb 4, 2026
23 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap Feb 4, 2026
@People-Sea People-Sea deleted the fix/issues/19196 branch February 5, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Livewire still tries to mount with actionJs on an Action

2 participants