Skip to content

fix: Select and KeyValue $watch timing edge cases#19202

Merged
danharrin merged 1 commit intofilamentphp:4.xfrom
People-Sea:fix/overlay-actions-component-state
Feb 4, 2026
Merged

fix: Select and KeyValue $watch timing edge cases#19202
danharrin merged 1 commit intofilamentphp:4.xfrom
People-Sea:fix/overlay-actions-component-state

Conversation

@People-Sea
Copy link
Contributor

@People-Sea People-Sea commented Feb 4, 2026

Description

Fix console errors in Select and KeyValue components.

  • Select: wrap $watch callback in $nextTick()
  • KeyValue: add Array.isArray() guard

These seem to be edge cases in Livewire/Alpine's reactivity timing. overlayParentActions() makes them easier to trigger, but they could possibly occur in other scenarios too.

Visual changes

Before

2026-02-04.21.37.26.mov

After

after.mov

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Roadmap Feb 4, 2026
@danharrin danharrin added the bug Something isn't working label Feb 4, 2026
@danharrin danharrin added this to the v4 milestone Feb 4, 2026
@danharrin danharrin merged commit 7275568 into filamentphp:4.x Feb 4, 2026
24 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap Feb 4, 2026
@People-Sea People-Sea deleted the fix/overlay-actions-component-state branch February 5, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants