Skip to content

fix: rebuild repeatable entry items after in-place collection mutation - #20500

Open
people-sea wants to merge 1 commit into
filamentphp:4.xfrom
people-sea:fix/repeatable-entry-cache
Open

people-sea wants to merge 1 commit into
filamentphp:4.xfrom
people-sea:fix/repeatable-entry-cache

Conversation

@people-sea

@people-sea people-sea commented Sep 14, 2026

Copy link
Copy Markdown
Member

Description

RepeatableEntry stores the Collection instance as its cached state, so in-place changes are not detected because both values point to the same object.

Cache the collection items as an array instead.

Visual changes

Functional changes

  • Code style has been checked with Pint and Rector.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@people-sea
people-sea marked this pull request as ready for review September 14, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant