FIP-0077: cleanup and match to current implementation#1140
Merged
Conversation
rvagg
requested review from
TippyFlitsUK,
anorth,
dannyob,
jennijuju,
jsoares,
lanzafame and
momack2
as code owners
Contributor
|
@rvagg Thank you for your efforts in refining and improving the updates to FIP-0077. I have thoroughly reviewed the updated draft and can confirm that it accurately reflects the intent of the proposal. |
tediou5
approved these changes
Apr 2, 2025
tediou5
left a comment
tediou5
left a comment
There was a problem hiding this comment.
Works well for me and doesn’t conflict with the current implementation.
ipfsforcezuofu
approved these changes
Apr 2, 2025
jennijuju
approved these changes
Apr 8, 2025
dannyob
approved these changes
Apr 22, 2025
github-project-automation
bot
moved this from 🔎 Awaiting Review
to ✔️ Approved by reviewer
in FilOz
github-project-automation
bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
rvagg
added a commit
that referenced
this pull request
May 20, 2025
jsoares
pushed a commit
that referenced
this pull request
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on and replaces #963 as an update to FIP-0077 to match the current proposal as it's evolved in the discussion and in the builtin-actors PR. It's a pretty heavy edit but the original one text seemed to have some challenges related to language so I took the liberty of just doing a full edit job on it and got it to match the current template a bit better.
@ipfsforcezuofu and @tediou5 I hope you don't mind that I've done so much heavy editing here; could you please review this and decide whether you'd be OK with this being the current form of the FIP draft?
btw I'm not making a statement here about the FIP itself, although I do understand the proposal now that I've done this, I'll comment further in the discussion thread but it would be good to get the draft updated at least so it can be considered further.