test: fetch actors bundle from github instead of using cargo#245
Merged
test: fetch actors bundle from github instead of using cargo#245
Conversation
Primarily, this removes an annoying circular dependency between these utilities and the actors. Additionally, this makes it very clear that the actors we're building won't use the code in this repo. Unlike normal rust builds, actor bundle builds don't automatically patch workspaces. I've configured it to fetch v15 and we'll have to update that as we go. If you want to test with newer actors, you'll need to build a bundle yourself and drop it in `testing/bundles/builtin-actors.car`. Part of filecoin-project/builtin-actors#1664
Stebalien
force-pushed
the
steb/actors-no-cargo
branch
from
98c2913 to
53397b8
Compare
rvagg
approved these changes
Mar 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
=======================================
Coverage ? 89.00%
=======================================
Files ? 27
Lines ? 5765
Branches ? 0
=======================================
Hits ? 5131
Misses ? 634
Partials ? 0 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily, this removes an annoying circular dependency between these utilities and the actors. Additionally, this makes it very clear that the actors we're building won't use the code in this repo. Unlike normal rust builds, actor bundle builds don't automatically patch workspaces.
I've configured it to fetch v15 and we'll have to update that as we go. If you want to test with newer actors, you'll need to build a bundle yourself and drop it in
testing/bundles/builtin-actors.car.Part of filecoin-project/builtin-actors#1664