Skip to content

Comments

fix(lint): ignore clippy result_large_err for now#254

Merged
ZenGround0 merged 1 commit intomainfrom
rvagg/clippy
Jun 2, 2025
Merged

fix(lint): ignore clippy result_large_err for now#254
ZenGround0 merged 1 commit intomainfrom
rvagg/clippy

Conversation

@rvagg
Copy link
Member

@rvagg rvagg commented May 30, 2025

not sure why this is failing now and not when the last rust upgrade happened

@rvagg rvagg requested review from ZenGround0 and Copilot May 30, 2025 08:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR temporarily disables the clippy lint for large error types across several files to bypass new failures observed after the recent Rust upgrade.

  • Temporarily allows clippy::result_large_err in multiple modules.
  • Applies lint suppression in four different files.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
testing/test_actors/actors/frc46_factory_token/token_impl/src/lib.rs Added lint allow attribute to ignore clippy::result_large_err.
testing/test_actors/actors/frc46_factory_token/src/lib.rs Added lint allow attribute to ignore clippy::result_large_err.
testing/test_actors/actors/basic_token_actor/src/lib.rs Added lint allow attribute to ignore clippy::result_large_err.
frc46_token/src/token/mod.rs Added lint allow attribute to ignore clippy::result_large_err.

@@ -1,3 +1,5 @@
#![allow(clippy::result_large_err)]
Copy link

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an inline comment to explain why the clippy lint for large errors is being ignored, including a reference to any related issue for future tracking.

Copilot uses AI. Check for mistakes.
@@ -1,3 +1,5 @@
#![allow(clippy::result_large_err)]
Copy link

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an inline comment to explain why the clippy lint for large errors is being ignored, including a reference to any related issue for future tracking.

Copilot uses AI. Check for mistakes.
@@ -1,3 +1,5 @@
#![allow(clippy::result_large_err)]
Copy link

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an inline comment to explain why the clippy lint for large errors is being ignored, including a reference to any related issue for future tracking.

Copilot uses AI. Check for mistakes.
@@ -1,3 +1,5 @@
#![allow(clippy::result_large_err)]
Copy link

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an inline comment to explain why the clippy lint for large errors is being ignored, including a reference to any related issue for future tracking.

Copilot uses AI. Check for mistakes.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.00%. Comparing base (962fa9d) to head (44f14c7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   89.00%   89.00%           
=======================================
  Files          27       27           
  Lines        5765     5765           
=======================================
  Hits         5131     5131           
  Misses        634      634           
Files with missing lines Coverage Δ
frc46_token/src/token/mod.rs 97.11% <ø> (ø)
...s/actors/frc46_factory_token/token_impl/src/lib.rs 76.71% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZenGround0 ZenGround0 merged commit 840198b into main Jun 2, 2025
3 checks passed
@ZenGround0 ZenGround0 deleted the rvagg/clippy branch June 2, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants