Improve the MillerLoopResult type.#64
Open
carloskiki wants to merge 3 commits intofilecoin-project:masterfrom
Open
Improve the MillerLoopResult type.#64carloskiki wants to merge 3 commits intofilecoin-project:masterfrom
MillerLoopResult type.#64carloskiki wants to merge 3 commits intofilecoin-project:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the pairing operations by extracting the Miller loop into a separate public function and adds new equality comparison capabilities to MillerLoopResult. It also removes the rust-toolchain file, allowing the MSRV specified in Cargo.toml to take precedence.
- Refactored
pairing()to use the newmiller_loop()function - Added
final_verify()method andPartialEq/Eqimplementations forMillerLoopResult - Removed
rust-toolchainfile to rely onrust-versionin Cargo.toml
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/pairing.rs | Extracts Miller loop into separate function, adds final_verify method and equality traits to MillerLoopResult, improves documentation |
| rust-toolchain | Removes toolchain specification file to use Cargo.toml MSRV |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
23b79fd to
9015201
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few issues with
MillerLoopResult.It makes it more usable. Currently, the type cannot be converted into a
Gtelement withfinal_exponentiation, which makes the type quite useless otherwise.It makes it coherent. The type documentation states that it can't be compared. However, the type still implements
PartialEqandEqwhich is contradictory. Moreover, the implementation ofEqandPartialEqwas wrong. It is known that twoMillerLoopResultsare not numerically equivalent. This fixes the type by adding afinal_verifymethod, and implementingEqandParitalEqbased on it.Allows for trivial construction. A
MillerLoopResultcan now be constructed using the top levelmiller_loopfunction.