build: don't build the bundle from the build script #1665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
steb/remove-build-script
branch
from
977e113 to
0d9e4be
Compare
With this change, we no longer build the bundle with the build script, exporting it as a global constant. Instead, we require users to either download the bundle from GitHub or build by executing the root package. This should reduce the slowness usually involved in running `cargo check --all` on this repo. fixes #1664
Stebalien
force-pushed
the
steb/remove-build-script
branch
from
0d9e4be to
4d19800
Compare
|
In terms of what this breaks:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we no longer build the bundle with the build script, exporting it as a global constant. Instead, we require users to either download the bundle from GitHub or build by executing the root package.
This should reduce the slowness usually involved in running
cargo check --allon this repo.fixes #1664