Skip to content

chore: bump serde to 1.0.226#1703

Merged
LesnyRumcajs merged 1 commit intomasterfrom
bump-serde
Sep 23, 2025
Merged

chore: bump serde to 1.0.226#1703
LesnyRumcajs merged 1 commit intomasterfrom
bump-serde

Conversation

@LesnyRumcajs
Copy link
Contributor

Pre-emptively bump serde t0 1.0.226 due to a breaking change in the API. I'm not sure why we used a private type from serde to be honest, especially given it's a re-export of a standard one.

dependencies = [
"data-encoding",
"syn 2.0.100",
"syn 1.0.109",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoa, a downgrade; is that normal and expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure why cargo decided to downgrade. I'll bump syn in a follow-up.

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private PhantomData is a bit odd, introduced here: 7027f02, and in the serde used there it was already available as a public. I think in this case if it compiles then that should be fine.

@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Sep 23, 2025
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Sep 23, 2025
Merged via the queue into master with commit 11e9f6c Sep 23, 2025
18 checks passed
@LesnyRumcajs LesnyRumcajs deleted the bump-serde branch September 23, 2025 14:31
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

2 participants