Skip to content

EIP-7951 (RIP-7212-compatible): secp256r1 P256VERIFY precompile #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snissn wants to merge 12 commits into
base: master
Choose a base branch
from
Open

EIP-7951 (RIP-7212-compatible): secp256r1 P256VERIFY precompile #1708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
be0a3af
add secp256r1.rs
aaravm Nov 13, 2025
1315bce
remove temp
aaravm Nov 13, 2025
89b9369
working tests
aaravm Nov 13, 2025
3b5d8e4
Add precompiles + cargo fmt
aaravm Dec 2, 2025
55c5a7c
adding rip72121 test
aaravm Dec 2, 2025
650a011
correct clippy error
aaravm Dec 2, 2025
4b63728
changing test vector to a vector from test suite
aaravm Dec 2, 2025
f8da0b8
remove unnecessary commits
aaravm Dec 3, 2025
dfe8b53
Add solidity tests
aaravm Dec 3, 2025
05d591b
Fix secp256r1 precompile docs and tests
snissn Jan 15, 2026
37c863c
Update ruint to address RUSTSEC-2025-0137
snissn Jan 16, 2026
fb09b9d
docs: align secp256r1 precompile naming
snissn Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
142 changes: 138 additions & 4 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions actors/evm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ exclude = ["/precompile-testdata", "/tests/measurements", "/tests/contracts"]
crate-type = ["cdylib", "lib"]

[dependencies]
p256 = { version = "0.13.2", features = ["ecdsa"], default-features = false }
fil_actors_runtime = { workspace = true }
fvm_shared = { workspace = true }
fvm_ipld_kamt = { workspace = true }
Expand All @@ -34,6 +35,7 @@ hex-literal = { workspace = true }
substrate-bn = { workspace = true }
thiserror = { workspace = true }
blst = "0.3.14"
alloy-core = { workspace = true }

[dev-dependencies]
hex = { workspace = true, features = ["serde"] }
Expand All @@ -44,6 +46,7 @@ alloy-core = { workspace = true }
serde_json = { workspace = true }
rand = { workspace = true }
once_cell = { workspace = true }
rstest = "0.26.0"


[features]
Expand Down
28 changes: 28 additions & 0 deletions actors/evm/src/interpreter/precompiles/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,15 @@ mod bls12_381;
mod bls_util;
mod evm;
mod fvm;
mod secp256r1;

use bls12_381::{
bls12_g1add, bls12_g1msm, bls12_g2add, bls12_g2msm, bls12_map_fp_to_g1, bls12_map_fp2_to_g2,
bls12_pairing,
};
use evm::{blake2f, ec_add, ec_mul, ec_pairing, ec_recover, identity, modexp, ripemd160, sha256};
use fvm::{call_actor, call_actor_id, get_randomness, lookup_delegated_address, resolve_address};
use secp256r1::p256_verify;

type PrecompileFn<RT> = fn(&mut System<RT>, &[u8], PrecompileContext) -> PrecompileResult;
pub type PrecompileResult = Result<Vec<u8>, PrecompileError>;
Expand All @@ -38,6 +40,16 @@ impl<RT: Runtime, const N: usize> PrecompileTable<RT, N> {
}

pub fn is_reserved_precompile_address(addr: &EthAddress) -> bool {
// Special case for secp256r1 (P-256) `P256VERIFY` precompile at 0x0100 (EIP-7951 / RIP-7212 interface).
if addr.0
== [
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x01, 0x00,
]
{
return true;
}

let [prefix, middle @ .., index] = addr.0;
(prefix == 0x00 || prefix == NATIVE_PRECOMPILE_ADDRESS_PREFIX)
&& middle == [0u8; 18]
Expand Down Expand Up @@ -80,6 +92,15 @@ impl<RT: Runtime> Precompiles<RT> {
]);

fn lookup_precompile(addr: &EthAddress) -> Option<PrecompileFn<RT>> {
// Special-case secp256r1 (P-256) `P256VERIFY` precompile at 0x...0100 (EIP-7951 / RIP-7212 interface).
if addr.0[0] == 0x00
&& addr.0[1..18] == [0u8; 17]
&& addr.0[18] == 0x01
&& addr.0[19] == 0x00
{
return Some(p256_verify::<RT>);
}

let [prefix, _m @ .., index] = addr.0;
if is_reserved_precompile_address(addr) {
let index = index as usize - 1;
Expand Down Expand Up @@ -217,6 +238,13 @@ mod test {
assert!(!is_reserved_precompile_address(&addr));
}

#[test]
fn is_rip_7212_precompile() {
Copy link

@redpanda-f redpanda-f Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All mentions of RIP 7212 should be removed.

EIP-7951 is the formal Ethereum Improvement Proposal that supersedes RIP-7212.
References (https://eips.ethereum.org/EIPS/eip-7951):

This specification addresses critical security issues discovered in RIP-7212 while maintaining full interface compatibility with existing Layer 2 implementations.

This EIP supersedes RIP-7212 by implementing the same functionality with the same interface, but without the vulnerability.

Copy link

@redpanda-f redpanda-f Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this should be part of this PR: but something like addr!(0x100) expanding to the full addr hex here should be easier for maintenance long term.

let addr = EthAddress(hex_literal::hex!("0000000000000000000000000000000000000100"));
assert!(Precompiles::<MockRuntime>::is_precompile(&addr));
assert!(is_reserved_precompile_address(&addr));
}

#[test]
fn zero_addr_precompile() {
let eth_addr = EthAddress(hex_literal::hex!("fe00000000000000000000000000000000000000"));
Expand Down
Loading