Open
Conversation
Contributor
Author
|
@LexLuthr I made the scheduler too fast and it exposed timing bugs in tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows tasks labelled "TimeSensitive" to bully other tasks out of resources to get started immediately. Other work is freed. Only the youngest set of blockers are chosen (and even then, the least possible).
Although this helps cases with those tasks, it needs to be added judiciously.
Though useful by itself,
This PR is part of an anti-starvation plan: the linear walk down the tasks in "importance order" must go away for a modified "oldest-first order" to fix starvation issues. When that happens, it's critical that time-sensitive tasks have an opt-out.