Dynamic Config #664
Draft
Dynamic Config #664
+241
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Oct 4, 2025
There was a problem hiding this comment.
Reads really well, I like how this refreshes fixed values a lot more than having that bloat directly in each instance of Dynamic.
I'd really like to have some Unit tests for the cursed reflect logic, AI should be pretty great at writing that sort of thing.
Also linters are complaining.
| } | ||
|
|
||
| func (r *cfgRoot) changeMonitor() { | ||
| lastTimestamp := time.Now().Add(-30 * time.Second) // plenty of time for start-up |
There was a problem hiding this comment.
I'd prefer some global flag for this. Large storage servers with millions of files on hard drives may need a few minutes for proper startup
| func() { | ||
| DynamicMx.Lock() | ||
| defer DynamicMx.Unlock() | ||
| ApplyLayers(context.Background(), r.treeCopy, configs) |
There was a problem hiding this comment.
Linter somewhat rightfully complains about a missing err check
| defer DynamicMx.Unlock() | ||
| ApplyLayers(context.Background(), r.treeCopy, configs) | ||
| }() | ||
| DynamicMx.Lock() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefit:
Compatible configs populate the latest value (with respect to the layers) every 30 seconds on running servers without restarting.
Work Remaining:
Decision-Points:
Punchlist (for future PRs):
-- XXMax P4, medium difficulty
-- StorageMarketConfig
--- MK12 - all here, P3, easy-ish
--- IPNI - no need?