Skip to content

fix: group by piece_id when calculating PieceCIDv2 for piece list #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
+18 −10
Merged

fix: group by piece_id when calculating PieceCIDv2 for piece list #675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions pdp/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,21 +561,29 @@ func (p *PDPService) handleGetDataSet(w http.ResponseWriter, r *http.Request) {
Pieces: []PieceEntry{}, // Initialize as empty array, not nil
}

// Calculate aggregate piece raw sizes by summing sub-piece raw sizes
pieceRawSizes := make(map[string]uint64)
// Calculate aggregate piece raw sizes by summing sub-piece raw sizes (group by piece_id)
pieceRawSizes := make(map[uint64]uint64)
for _, piece := range pieces {
pieceRawSizes[piece.PieceCid] += piece.SubPieceRawSize
pieceRawSizes[piece.PieceID] += piece.SubPieceRawSize
}

aggregatePieceCIDs := make(map[uint64]string)

// Convert pieces to the desired JSON format
for _, piece := range pieces {
// Use the summed raw size for the aggregate piece
aggregateRawSize := pieceRawSizes[piece.PieceCid]
pcv2, _, err := asPieceCIDv2(piece.PieceCid, aggregateRawSize)
if err != nil {
http.Error(w, "Invalid PieceCID: "+err.Error(), http.StatusBadRequest)
return
// Calculate aggregate piece CID on first use for this piece_id
pcv2Str, exists := aggregatePieceCIDs[piece.PieceID]
if !exists {
aggregateRawSize := pieceRawSizes[piece.PieceID]
pcv2, _, err := asPieceCIDv2(piece.PieceCid, aggregateRawSize)
if err != nil {
http.Error(w, "Invalid PieceCID: "+err.Error(), http.StatusBadRequest)
return
}
pcv2Str = pcv2.String()
aggregatePieceCIDs[piece.PieceID] = pcv2Str
}

// Use the raw size for the sub piece
spcv2, _, err := asPieceCIDv2(piece.SubPieceCID, piece.SubPieceRawSize)
if err != nil {
Expand All @@ -584,7 +592,7 @@ func (p *PDPService) handleGetDataSet(w http.ResponseWriter, r *http.Request) {
}
response.Pieces = append(response.Pieces, PieceEntry{
PieceID: piece.PieceID,
PieceCID: pcv2.String(),
PieceCID: pcv2Str,
SubPieceCID: spcv2.String(),
SubPieceOffset: piece.SubPieceOffset,
})
Expand Down