Skip to content

fix: nil point deference in addPiece #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
+4 −4
Merged

fix: nil point deference in addPiece #677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pdp/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@ func (p *PDPService) handleAddPieceToDataSet(w http.ResponseWriter, r *http.Requ

// Collect all subPieceCids to fetch their info in a batch
subPieceCidSet := make(map[string]struct{})
for i, addPieceReq := range payload.Pieces {
for _, addPieceReq := range payload.Pieces {
if addPieceReq.PieceCID == "" {
http.Error(w, "PieceCID is required for each piece", http.StatusBadRequest)
return
Expand All @@ -722,7 +722,7 @@ func (p *PDPService) handleAddPieceToDataSet(w http.ResponseWriter, r *http.Requ
return
}

for _, subPieceEntry := range addPieceReq.SubPieces {
for i, subPieceEntry := range addPieceReq.SubPieces {
if subPieceEntry.SubPieceCID == "" {
http.Error(w, "subPieceCid is required for each subPiece", http.StatusBadRequest)
return
Expand Down Expand Up @@ -820,7 +820,7 @@ func (p *PDPService) handleAddPieceToDataSet(w http.ResponseWriter, r *http.Requ
pieceInfos := make([]abi.PieceInfo, len(addPieceReq.SubPieces))

var totalOffset uint64 = 0
for i, subPieceEntry := range addPieceReq.SubPieces {
for j, subPieceEntry := range addPieceReq.SubPieces {
subPieceInfo, exists := subPieceInfoMap[subPieceEntry.subPieceCIDv1]
if !exists {
return false, fmt.Errorf("subPiece CID %s not found in subPiece info map", subPieceEntry.subPieceCIDv1)
Expand All @@ -830,7 +830,7 @@ func (p *PDPService) handleAddPieceToDataSet(w http.ResponseWriter, r *http.Requ
subPieceInfo.SubPieceOffset = totalOffset
subPieceInfoMap[subPieceEntry.subPieceCIDv1] = subPieceInfo // Update the map

pieceInfos[i] = abi.PieceInfo{
pieceInfos[j] = abi.PieceInfo{
Size: subPieceInfo.PaddedSize,
PieceCID: subPieceInfo.PieceCIDv1,
}
Expand Down