Conversation
Contributor
Author
|
I will add a test for the eth_client by moving money between wallets and back after a failover (how many lotus nodes, stop). |
Contributor
Then reverting back to main: 
|
Contributor
Author
|
Reiers testing: |
magik6k
reviewed
Dec 8, 2025
Collaborator
magik6k
left a comment
magik6k
left a comment
There was a problem hiding this comment.
Few minor things to address, looks really great!
Collaborator
There was a problem hiding this comment.
Definitely must do some manual testing on this
Contributor
Author
There was a problem hiding this comment.
I have no idea how, so review itests/eth_test.go
Collaborator
There was a problem hiding this comment.
This just adds a 'on new insert' handling? Any issue this is fixing?
Contributor
Author
There was a problem hiding this comment.
AI talked me into something that i should not have been. It thought some test failure was related to this AFTER trigger needing to be a BEFORE, then the test cleaned-up, but I think that line of thinking was garbage: file deleted
Reiers
requested changes
Mar 20, 2026
Contributor
Reiers
left a comment
Reiers
left a comment
There was a problem hiding this comment.
Nil pointer crash when a config layer omits a *Dynamic[T] field (e.g. ChainApiInfo absent from a layer). Set() and Get() dereference the receiver without nil checks, but GetWithoutLock() already has one.
Startup panic:
panic: runtime error: invalid memory address or nil pointer dereference
config.(*Dynamic[...]).Set()
deps.GetFullNodeAPIV1Curio.func2()
Two suggestions below. SetWithoutLock() and OnChange() need the same guard but aren't in this diff.
| } | ||
|
|
||
| // It locks dynamicLocker, unless we're already in an updating context. | ||
| func (d *Dynamic[T]) Set(value T) { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (d *Dynamic[T]) Set(value T) { | |
| func (d *Dynamic[T]) Set(value T) { | |
| if d == nil { | |
| return | |
| } |
| @@ -69,19 +80,23 @@ func (d *Dynamic[T]) SetWithoutLock(value T) { | |||
| func (d *Dynamic[T]) Get() T { | |||
Contributor
There was a problem hiding this comment.
Suggested change
| func (d *Dynamic[T]) Get() T { | |
| func (d *Dynamic[T]) Get() T { | |
| if d == nil { | |
| var zero T | |
| return zero | |
| } |
Reiers
requested changes
Mar 20, 2026
Contributor
Reiers
left a comment
Reiers
left a comment
There was a problem hiding this comment.
One more dead-code bug from the Dynamic conversion.
Comment on lines
209
to
+210
| if baseCfg.Apis.ChainApiInfo == nil { | ||
| baseCfg.Apis.ChainApiInfo = append(baseCfg.Apis.ChainApiInfo, chainApiInfo) | ||
| baseCfg.Apis.ChainApiInfo.Set(append(baseCfg.Apis.ChainApiInfo.Get(), chainApiInfo)) |
Contributor
There was a problem hiding this comment.
Pointer is never nil after NewDynamic([]string{}). Matches the fix already at line 312.
Suggested change
| if baseCfg.Apis.ChainApiInfo == nil { | |
| baseCfg.Apis.ChainApiInfo = append(baseCfg.Apis.ChainApiInfo, chainApiInfo) | |
| baseCfg.Apis.ChainApiInfo.Set(append(baseCfg.Apis.ChainApiInfo.Get(), chainApiInfo)) | |
| if len(baseCfg.Apis.ChainApiInfo.Get()) == 0 { | |
| baseCfg.Apis.ChainApiInfo.Set(append(baseCfg.Apis.ChainApiInfo.Get(), chainApiInfo)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds atop PR #710 (which implemented P1 items) to implement P2 & P3 items of the following punchlist.
Logic fixes: forgot 'base' changes! Atomic where better.
New component: working with Dynamic[struct{...}] required a new approach.
Misc_Included_Commits
Better testing separation by guaranteeing different databases used.
SQL:
PunchList
The remaining items are P4-5 and "No need"
Subsystems
Fees - all P2, easy, done
Addresses - all P1, hard, done
Proving - all, P4, easy
Http - no need
Market
-- MK12 - all here, P3, easy-ish, done
-- MK2, P3, done
Ingest - P1, done
Seal - No need
APIs->Chain - P2, medium-hard, done
Alerting - P3, easy, done
Batching - P2, easy, done
todo: startup fails?