Skip to content

fix: show error on upload failure #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: show error on upload failure #71

wants to merge 5 commits into from

Conversation

SgtPooki
Copy link
Collaborator

@SgtPooki SgtPooki commented Oct 15, 2025 •
edited
Loading

  • fix: show upload error and require user interaction
  • fix: upload while waiting on dataset, and error show

Simulated the below by setting network to offline in browser in the middle of an upload:

image

cc @barbaraperic @CharlyMartin likely need some fixes in upload-error.tsx

@vercel Vercel
Copy link

vercel bot commented Oct 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
filecoin-pin-website Ready Ready Preview Comment Oct 16, 2025 11:02am

@github-actions GitHub Actions
Copy link

Filecoin Pin Upload

IPFS Artifacts:

Onchain verification:

Payment:

  • Current Filecoin Pay balance: 1116.3342 USDFC

  • Amount deposited to Filecoin Pay by this workflow: 0.0000 USDFC

  • Data Set Storage runway: 12846 year(s) 10 month(s) 11 day(s)

    More details

@github-actions GitHub Actions
Copy link

Filecoin Pin Upload

IPFS Artifacts:

Onchain verification:

Payment:

  • Current Filecoin Pay balance: 1116.3342 USDFC

  • Amount deposited to Filecoin Pay by this workflow: 0.0000 USDFC

  • Data Set Storage runway: 12825 year(s) 9 month(s) 17 day(s)

    More details

@barbaraperic
Copy link
Collaborator

Sounds good, we'll sync with Filipa on the design and fix. Would you prefer it to be in the same PR, or is a separate one fine?

@SgtPooki
Copy link
Collaborator Author

Sounds good, we'll sync with Filipa on the design and fix. Would you prefer it to be in the same PR, or is a separate one fine?

Your call, no preference here

@barbaraperic
Copy link
Collaborator

@SgtPooki here's the rework with Filipa's design - @CharlyMartin I've made some adjustments to the Alert component, let me know what you think!

Screenshot 2025-10-16 at 10 27 12

@github-actions GitHub Actions
Copy link

Filecoin Pin Upload

IPFS Artifacts:

Onchain verification:

Payment:

  • Current Filecoin Pay balance: 1116.3342 USDFC

  • Amount deposited to Filecoin Pay by this workflow: 0.0000 USDFC

  • Data Set Storage runway: 11195 year(s) 11 month(s) 24 day(s)

    More details

@CharlyMartin
refactor(ui): enhance Alert and Button components with size variants …
4d216f0 
…and improved styling

- Split button variants in Alert for better maintainability and added secondary styles
- Introduced size prop and unstyled variant in ButtonBase for flexibility
- Updated icon type and refactored button rendering for consistency and reusability
@CharlyMartin
Copy link
Collaborator

I added proper variants to all secondary buttons. Good to merge!

CleanShot 2025-10-16 at 11 59 22

@github-actions GitHub Actions
Copy link

Filecoin Pin Upload

IPFS Artifacts:

Onchain verification:

Payment:

  • Current Filecoin Pay balance: 1116.3342 USDFC

  • Amount deposited to Filecoin Pay by this workflow: 0.0000 USDFC

  • Data Set Storage runway: 11168 year(s) 1 day(s)

    More details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CharlyMartin CharlyMartin CharlyMartin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SgtPooki @barbaraperic @CharlyMartin