-
Notifications
You must be signed in to change notification settings - Fork 3
fix: retry on CreateDataSet nonce collision #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Filecoin Pin UploadIPFS Artifacts:
Onchain verification:
Payment:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this actually looks really straightforward for the dataset creation failures
i'm going to test this locally with two (or more) simultaneous new private windows and merge if it works |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
it looks like a react-state error needs to be fixed. we're currently preventing duplicate data-set creation requests, and that doesn't seem to be handled here:
will fix |
@rvagg @BigLep it looks like we need a longer wait if there's a collision.. because one of the users (private browser instances for me) started creating a dataset, and the other got to the 4 retries almost instantely and just failed with the same error.. the data set creation needs to wait at least |
oh whoops, I thought I had a wait in here anyway, let's hold off on this, we'll get this sorted soon enough with nonsequential nonces |
Ref: https://filecoinproject.slack.com/archives/C095WFA0QK1/p1760475750636059
There are two variations of the errors that we can expect to receive from the server, for reasons: