fix: pad rawSize for payment calculations #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calculateRequiredAllowances(), supposedly, is the entry point for all the calculate* functions in /core/payments. calling padSizeToPDPLeaves once in it, shares that converted with the rest.
Author
|
how does this look, @SgtPooki? |
SgtPooki
requested changes
Nov 20, 2025
src/core/payments/constants.ts
Outdated
Comment on lines
61
to
69
| /** | ||
| * Pad raw size to the next multiple of 32 bytes | ||
| * | ||
| * @param rawSizeBytes - The actual size in bytes | ||
| * @returns Padded size (next multiple of 32) | ||
| */ | ||
| export function padSizeToPDPLeaves(rawSizeBytes: number): number { | ||
| return Math.ceil(rawSizeBytes / PDP_LEAF_SIZE) * PDP_LEAF_SIZE | ||
| } |
Collaborator
There was a problem hiding this comment.
this shouldn't go in constants.ts it should probably go in a new file: /core/payments/utils.ts
Author
There was a problem hiding this comment.
alright. let me update that.
| */ | ||
| export function calculateRequiredAllowances(pieceSizeBytes: number, pricePerTiBPerEpoch: bigint): StorageAllowances { | ||
| const storageTiB = pieceSizeBytes / Number(SIZE_CONSTANTS.TiB) | ||
| const paddedSizeBytes = padSizeToPDPLeaves(pieceSizeBytes) |
Collaborator
There was a problem hiding this comment.
There are a lot of other places where we use pieceSizeBytes.
your util function is correct, but I'm worried we're missing a few places.. this might need to wait until we clean up src/core/payments
Author
There was a problem hiding this comment.
sounds, good.
let me find some of them while you're doing the cleanup. what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calculateRequiredAllowances(), supposedly, is the entry point for all the calculate* functions in /core/payments.calling
padSizeToPDPLeavesonce in it, shares that converted value with the rest.closes #213