Skip to content

fix: support mainnet CLI network and payment guidance#353

Merged
rvagg merged 3 commits intomasterfrom
fix-mainnet-cli-flow
Mar 9, 2026
Merged

fix: support mainnet CLI network and payment guidance#353
rvagg merged 3 commits intomasterfrom
fix-mainnet-cli-flow

Conversation

@davidgasquez
Copy link
Collaborator

Fixes #352

  • propagate --mainnet and network selection through CLI auth and RPC resolution
  • reuse a single helper for mainnet USDFC acquisition guidance in validation and payments status
  • make config defaults tests independent from ambient NETWORK and RPC_URL

Validation:

npm test
# Test Files  35 passed (35)
# Tests  336 passed | 11 skipped (347)

@FilOzzy FilOzzy added team/filecoin-pin "Filecoin Pin" project is a stakeholder for this work. team/fs-wg FOC working group is a stakeholder for this work, and thus wants to track it on their project board. labels Mar 6, 2026
@FilOzzy FilOzzy added this to FOC Mar 6, 2026
@github-project-automation github-project-automation bot moved this to 📌 Triage in FOC Mar 6, 2026
@rjan90 rjan90 requested review from juliangruber and rvagg March 6, 2026 14:31
@BigLep BigLep marked this pull request as ready for review March 6, 2026 15:42
@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FOC Mar 6, 2026
Comment on lines +29 to +30
/** Commander shorthand for --network mainnet */
mainnet?: boolean | undefined
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** Commander shorthand for --network mainnet */
mainnet?: boolean | undefined

@rvagg
Copy link
Member

rvagg commented Mar 9, 2026

I pushed another commit that removes a few things, commander's implies() does most of the validation work for us with --mainnet and --network so we shouldn't be double-validating. Passing on the chain is the main fix here, the USDFC additions are very nice, and the env cleanup is good too.

@rvagg rvagg merged commit 3e4e330 into master Mar 9, 2026
12 checks passed
@rvagg rvagg deleted the fix-mainnet-cli-flow branch March 9, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team/filecoin-pin "Filecoin Pin" project is a stakeholder for this work. team/fs-wg FOC working group is a stakeholder for this work, and thus wants to track it on their project board.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mainnet CLI network selection and USDFC guidance regressions

4 participants