feat: add devnet network support and --skip-ipni flag#354
feat: add devnet network support and --skip-ipni flag#354
Conversation
Support --network devnet using foc-devnet's devnet-info.json via synapse-core's toChain(). Private key auto-resolves from devnet user. Add --skip-ipni flag for add/import commands, auto-enabled on devnet. Closes: #348
FilOzzy
added
team/filecoin-pin
|
Actually it ended up bothering me and it wasn't hard to deal with; URLs adjusted for devnet as a special case 
|
| /** Data set metadata applied when creating or updating the storage context */ | ||
| dataSetMetadata?: Record<string, string> | ||
| /** Skip IPNI advertisement verification after upload */ | ||
| skipIpni?: boolean |
There was a problem hiding this comment.
This option reads like it would skip announcement, not verification: "should I skip IPNI during add?"
There was a problem hiding this comment.
we should also change the CLI after this rename (if we agree)
There was a problem hiding this comment.
maybe skipIpniVerification
There was a problem hiding this comment.
I had similar thought when I saw the flag. Basicly want to make clear that we're still asking SP to announce the advertisment, but we're not going to confirm that IPNI has the advertisement. So yeah, either of the proposals seem good to me.
SgtPooki
left a comment
SgtPooki
left a comment
There was a problem hiding this comment.
could be useful to add some notes to DEVELOPMENT.md on how to set this up for future users, linking to foc-devnet repo setup instructions
| /** Data set metadata applied when creating or updating the storage context */ | ||
| dataSetMetadata?: Record<string, string> | ||
| /** Skip IPNI advertisement verification after upload */ | ||
| skipIpni?: boolean |
There was a problem hiding this comment.
maybe skipIpniVerification
| metadata?: Record<string, string> | ||
|
|
||
| /** Skip IPNI advertisement verification after upload */ | ||
| skipIpni?: boolean |
There was a problem hiding this comment.
ditto to Julian's other comment
| /** Data set metadata applied when creating or updating the storage context */ | ||
| dataSetMetadata?: Record<string, string> | ||
| /** Skip IPNI advertisement verification after upload */ | ||
| skipIpni?: boolean |
There was a problem hiding this comment.
ditto to Julian's other comment
| .choices(['mainnet', 'calibration']) | ||
| new Option( | ||
| '--network <network>', | ||
| 'Filecoin network to use. "devnet" reads config from foc-devnet ' + |
There was a problem hiding this comment.
| 'Filecoin network to use. "devnet" reads config from foc-devnet ' + | |
| 'Filecoin network to use. "devnet" reads config from foc-devnet.json ' + |
6 participants
--network devnetusing foc-devnet's devnet-info.json via synapse-core'stoChain(). Private key auto-resolves from devnet user.--skip-ipniflag for add/import commands, auto-enabled on devnet.Closes: #348
^ URLs aren't going to work there obviously .. but I'm not sure it's worth chasing those down and turning them off, hopefully any devnet user will know that they are meaningless.