fix: MacOs typescript error on running locally resolved #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Link to issue #399
Please add a link to any relevant issues/tickets
#399
Type of change:
package.json for snap package was updated to resolve the build time typescript error
react and react-dom was added to fix error related to not having react and react-dom but using react/types
[These were added because packages/snap is also rendering React UI and without these local errors were appearing]
to fix issues associated with types clash between React’s JSX types and the Snaps JSX, tsconfig has been updated
[The Snap UI (Box, Header, Section, etc.) is from @metamask/snaps-sdk/jsx, which defines its own JSX.Element (“SnapElement”). Because @types/react is in scope, TypeScript is trying to validate those components as React elements (ReactNode) and rejects them → TS2786. Fixed by isolating React types out of the snap package and telling TS to use the Snaps JSX runtime.]
Please delete options that are not relevant.
Screenshots: