feat: fip-0109 SectorContentChanged notification#14
Draft
wjmelements wants to merge 16 commits intomainfrom
Draft
feat: fip-0109 SectorContentChanged notification#14wjmelements wants to merge 16 commits intomainfrom
wjmelements wants to merge 16 commits intomainfrom
Conversation
- Add FVMSectorContentChanged with structs + CBOR encode/decode - Add FVMMinerActor mock (etched at masked ID address) - Extend FVMCallActorById with PowerAPI minerPower support - Add maskedAddress/actorId/safeActorId to FVMAddress - Add SECTOR_CONTENT_CHANGED, MINER_POWER to FVMMethod - Add CBOR_CODEC to FVMCodec - Update MockFVMTest with mockMiner() helper Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…anged Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
The |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…22% gas Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ner fallback Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pali101
reviewed
Mar 22, 2026
src/FVMErrors.sol
Outdated
|
|
||
| // Actor user exit codes (positive, ExitCode in fvm_shared::error) | ||
| // See https://docs.rs/fvm_shared/latest/fvm_shared/error/struct.ExitCode.html | ||
| uint32 constant USR_NOT_FOUND = 14; |
Contributor
There was a problem hiding this comment.
Suggested change
| uint32 constant USR_NOT_FOUND = 14; | |
| uint32 constant USR_NOT_FOUND = 17; |
According to fvm_shared::error::ExitCode, USR_NOT_FOUND should be 17, not 14. The other two constants in this block (USR_ILLEGAL_ARGUMENT = 16, USR_UNHANDLED_MESSAGE = 22) are correct.
pali101
reviewed
Mar 22, 2026
Co-authored-by: Aashish Paliwal <aashish.paliwal@live.com>
…UND value Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer @pali101
CC @lordshashank
Changes