Skip to content

fip-0100: update the vesting funds types to the new layout#353

Merged
Stebalien merged 1 commit intosteb/fip-0100/base-miner-migrationfrom
steb/fip-0100/vesting-funds-changes
Feb 27, 2025
Merged

fip-0100: update the vesting funds types to the new layout#353
Stebalien merged 1 commit intosteb/fip-0100/base-miner-migrationfrom
steb/fip-0100/vesting-funds-changes

Conversation

@Stebalien
Copy link
Copy Markdown
Member

@Stebalien Stebalien commented Feb 27, 2025

I've also changed the LoadVestingFunds to return a []VestingFund so we can abstract across the different underlying representations.

fixes #350

@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Feb 27, 2025
@Stebalien Stebalien force-pushed the steb/fip-0100/vesting-funds-changes branch from bc3a715 to 99fd277 Compare February 27, 2025 00:02
@Stebalien Stebalien changed the title feat(v16): update the vesting funds types to the new layout fip-0100: update the vesting funds types to the new layout Feb 27, 2025
@Stebalien Stebalien requested a review from rvagg February 27, 2025 00:03
I've also changed the `LoadVestingFunds` to return a `[]VestingFund` so
we can abstract across the different underlying representations.

related to filecoin-project/builtin-actors#1636
@Stebalien Stebalien force-pushed the steb/fip-0100/vesting-funds-changes branch from 99fd277 to 9cf2895 Compare February 27, 2025 00:05
@Stebalien Stebalien linked an issue Feb 27, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice that we shave off those enclsoing array bytes with the new transparent form too

@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Feb 27, 2025
@Stebalien Stebalien merged commit d0d2748 into steb/fip-0100/base-miner-migration Feb 27, 2025
8 checks passed
@Stebalien Stebalien deleted the steb/fip-0100/vesting-funds-changes branch February 27, 2025 00:12
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Feb 27, 2025
@Stebalien Stebalien restored the steb/fip-0100/vesting-funds-changes branch February 27, 2025 00:13
@rvagg rvagg deleted the steb/fip-0100/vesting-funds-changes branch February 27, 2025 00:13
@Stebalien
Copy link
Copy Markdown
Member Author

Gah. Wrong merge order.

@Stebalien Stebalien restored the steb/fip-0100/vesting-funds-changes branch February 27, 2025 00:14
@BigLep BigLep moved this from 🐱 Todo to 🎉 Done in nv25 Track Board Feb 27, 2025
@rjan90 rjan90 moved this from 🎉 Done to ☑️ Done (Archive) in FilOz Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ☑️ Done (Archive)
Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

FIP-0100: Update Miner VestingFunds

4 participants