fip-0100: sectoronchaininfo, deadline and expirationset type changes#359
Merged
rvagg merged 1 commit intofeat/fip-0100from Mar 6, 2025
Merged
fip-0100: sectoronchaininfo, deadline and expirationset type changes#359rvagg merged 1 commit intofeat/fip-0100from
rvagg merged 1 commit intofeat/fip-0100from
Conversation
c81bb3e to
792b023
Compare
792b023 to
d3ca895
Compare
Member
Author
|
@Stebalien this is good to go but with the |
Stebalien
approved these changes
Mar 6, 2025
Member
Stebalien
left a comment
There was a problem hiding this comment.
I'd say merge this as-is for now while we figure out the nil/zero stuff. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs one of whyrusleeping/cbor-gen#111 or whyrusleeping/cbor-gen#112 first; and this isn't complete, I have ExpirationSet and Deadline serialization tests to add to match https://github.com/filecoin-project/builtin-actors/blob/481e18161e0af9a9a076327569c4e90fccf23fb6/actors/miner/tests/types_test.rs