Skip to content

fip-0100: sectoronchaininfo, deadline and expirationset type changes#359

Merged
rvagg merged 1 commit intofeat/fip-0100from
rvagg/fip-0100/type-updates
Mar 6, 2025
Merged

fip-0100: sectoronchaininfo, deadline and expirationset type changes#359
rvagg merged 1 commit intofeat/fip-0100from
rvagg/fip-0100/type-updates

Conversation

@rvagg
Copy link
Copy Markdown
Member

@rvagg rvagg commented Mar 5, 2025

Needs one of whyrusleeping/cbor-gen#111 or whyrusleeping/cbor-gen#112 first; and this isn't complete, I have ExpirationSet and Deadline serialization tests to add to match https://github.com/filecoin-project/builtin-actors/blob/481e18161e0af9a9a076327569c4e90fccf23fb6/actors/miner/tests/types_test.rs

@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Mar 5, 2025
@rvagg rvagg force-pushed the rvagg/fip-0100/type-updates branch from c81bb3e to 792b023 Compare March 5, 2025 23:22
@rvagg rvagg marked this pull request as ready for review March 5, 2025 23:26
@rvagg rvagg force-pushed the rvagg/fip-0100/type-updates branch from 792b023 to d3ca895 Compare March 5, 2025 23:29
@rvagg
Copy link
Copy Markdown
Member Author

rvagg commented Mar 5, 2025

@Stebalien this is good to go but with the big.Int{} uninitialised. For now it's just documented where it matters that you need to take care touching that value. I think in practice that the only one that will be used (outside of invariants checks) is SectorOnChainInfo.DailyFee but it's going to be used in serialized form for the API and the serialisers already treat nil as zero so I think that should be fine. It might matter if miner software starts touching it though.

Copy link
Copy Markdown
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say merge this as-is for now while we figure out the nil/zero stuff. LGTM.

@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Mar 6, 2025
@rvagg rvagg merged commit a229ffc into feat/fip-0100 Mar 6, 2025
8 checks passed
@rvagg rvagg deleted the rvagg/fip-0100/type-updates branch March 6, 2025 02:12
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Mar 6, 2025
@github-project-automation github-project-automation bot moved this to 🐱 Todo in nv25 Track Board Mar 6, 2025
@BigLep BigLep moved this from 🐱 Todo to 🎉 Done in nv25 Track Board Mar 6, 2025
@rjan90 rjan90 moved this from 🎉 Done to ☑️ Done (Archive) in FilOz Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ☑️ Done (Archive)
Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

4 participants