fip-0100: add Deadline & Deadlines migration, summing LivePower#361
Merged
Stebalien merged 1 commit intofeat/fip-0100from Mar 7, 2025
Merged
fip-0100: add Deadline & Deadlines migration, summing LivePower#361Stebalien merged 1 commit intofeat/fip-0100from
Stebalien merged 1 commit intofeat/fip-0100from
Conversation
rvagg
force-pushed
the
rvagg/fip-0100/deadline-migration
branch
from
99c313b to
027ead6
Compare
Stebalien
approved these changes
Mar 7, 2025
| EarlyTerminations: oldDeadline.EarlyTerminations, | ||
| LiveSectors: oldDeadline.LiveSectors, | ||
| TotalSectors: oldDeadline.TotalSectors, | ||
| FaultyPower: miner16.NewPowerPair(oldDeadline.FaultyPower.Raw, oldDeadline.FaultyPower.QA), |
Member
There was a problem hiding this comment.
Ew. We really should move power pair into some form of shared type package.
Member
Author
There was a problem hiding this comment.
Yes, I'm mentally making a list. I did Batch return already but we just need to do all the utility types that don't change.
github-project-automation
bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FilOz
github-project-automation
bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
rvagg
added a commit
that referenced
this pull request
Mar 10, 2025
rvagg
added a commit
that referenced
this pull request
Mar 14, 2025
rjan90
pushed a commit
that referenced
this pull request
Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.