You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you end up changing the way that trustless-utils handles ranges, you may find that the e2e test in here fails; because frisbii is using the same logic to serve that data, so it's a matter of making the changes flow through the set of things, frisbii first and then lassie. i.e. e2e failing here isn't necessarily a problem and should be easily fixable if we agree that the change is correct and should be bubbled up through the stack.
this is a worthwhile effort but given the time passed + divergence on all fronts + concerns about whether this is the right interface at which to evaluate conformance I think we should close; I don't have enough context to make the call though, so perhaps @rvagg you could chime in?
Would be good to do, the conformance tests track the spec properly now and will pick up issues if you're not tracking the spec - I don't track it actively and they still make chances so it's one way of being aware of those changes. @lidel showed up and added it to frisbii and it was much easier than I expected it would be and it's been helpful there: ipld/frisbii#214, it caught ipld/go-trustless-utils#62 which I'd have no reason to know was a spec change without those tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the official test of trustless gateway lives in ipfs/gateway-conformance, adding the test here.
Still working on this, especially cause we're not currently passing.