Skip to content

fix(rpc): add read, write and idle timeout to rpc handler #13283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(rpc): add read, write and idle timeout to rpc handler #13283

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
832ffef
fix(rpc): Adding read, write and idle timeout to rpc handler
parthshah1 Aug 27, 2025
a46b209
adding the values as constants
parthshah1 Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion node/rpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,15 @@ import (

var rpclog = logging.Logger("rpc")

const (
// HTTP server timeout constants
readHeaderTimeout = 10 * time.Second
readTimeout = 60 * time.Second
writeTimeout = 60 * time.Second
idleTimeout = 60 * time.Second
maxHeaderBytes = 1 << 20
)

// ServeRPC serves an HTTP handler over the supplied listen multiaddr.
//
// This function spawns a goroutine to run the server, and returns immediately.
Expand All @@ -47,7 +56,11 @@ func ServeRPC(h http.Handler, id string, addr multiaddr.Multiaddr) (StopFunc, er
// Instantiate the server and start listening.
srv := &http.Server{
Handler: h,
ReadHeaderTimeout: 30 * time.Second,
ReadHeaderTimeout: readHeaderTimeout,
ReadTimeout: readTimeout,
WriteTimeout: writeTimeout,
IdleTimeout: idleTimeout,
MaxHeaderBytes: maxHeaderBytes,
BaseContext: func(listener net.Listener) context.Context {
ctx := context.Background()
ctx = metrics.AddNetworkTag(ctx)
Expand Down
Loading