-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(cli): add FRC-102 compatible EIP-191 signing via --fevm flag (#13256) #13388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(cli): add FRC-102 compatible EIP-191 signing via --fevm flag (#13256) #13388
Conversation
1178fb7 to
07c15b7
Compare
|
Hi all 👋 Just wanted to follow up on this PR. |
|
@hugomrdias @eshon @bumblefudge can you help us out here -- this PR does two things, it changes the default signature to be the version |
in this command we only care about 0x46 "personal_sign", filsnap and ledger only implement 0x46 for personal messages. yes, its a breaking change there no more unprefixed signatures exactly frc-0102 purpose https://github.com/hugomrdias/filecoin/blob/main/packages/iso-filecoin/src/wallet.js#L274-L285 |
Signed-off-by: Angelina <[email protected]>
OK, @aceppaluni would you mind please just removing the But then also, we need to fix the "verify" command to be the reverse of |
Related Issues
This PR aims to fix Issue #13256
Proposed Changes
This PR updates the
lotus wallet signcommand to implement FRC-102, allowing users to sign messages with an EIP-191 (Ethereum-style) prefix for FEVM compatibility.Additional Info
--fevmflag towallet signcommand.Checklist
Before you mark the PR ready for review, please make sure that: