-
Notifications
You must be signed in to change notification settings - Fork 315
v19.0.1 #1788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
v19.0.1 #1788
Conversation
ca84c57
to
b619a7f
Compare
hah, lack of a checked in lock even shows up in CI failures, it's failing in CI because it's pulling in newer dependencies that aren't in the release lock I think we just need to check in a lockfile |
fdbf0b2
to
d737f8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the project to version 19.0.1, primarily to update the supraseal-c2 dependency to 0.1.1 for improved GPU compatibility. Additionally, it addresses release process improvements by adding tooling to compare lockfile changes between releases.
- Update supraseal-c2 from 0.1.0 to 0.1.1 for better GPU support
- Add Python script to compare Cargo.lock files between releases
- Update release documentation to emphasize proper lockfile management
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
scripts/compare-locks.py | New utility script for comparing Cargo.lock files between releases |
fil-proofs-param/Cargo.toml | Update indicatif dependency from 0.16.2 to 0.17 |
RELEASE.md | Enhanced release instructions with lockfile management guidance |
CHANGELOG.md | Added changelog entry for v19.0.1 with dependency updates |
.github/actions/proof-params-download/action.yml | Improved curl command with error handling and directory creation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sounds good. Will you be doing that as part of this PR? Is that what is needed to get CI green? |
FYI that created a tracking issue for bubbling this up through filecoin-ffi: filecoin-project/filecoin-ffi#540 |
5b4f1df
to
eafe982
Compare
eafe982
to
9b874bd
Compare
a185d80
to
d806595
Compare
d806595
to
851f4fc
Compare
As an aside, there is a supraseal-c2 0.1.2 out this weekend. But it has a new build system thanks to sppark v0.1.14 and our CI isn't happy with that and we get a panic. I think it might just be a case of adding an env var - https://github.com/supranational/sppark/blob/443e31e13c2bfefefe11ab985f938bb0c3a6907c/rust/src/build.rs#L22 - Just a build system update, so I didn't think it worth chasing for this update. Maybe there's more I'm missing though. |
Main goal here is to get supraseal-c2 updated so people can use more recent GPUs for sealing.
This caught my interest so I went investigating and the lack of a checked in lockfile bothered me. It'd be fine if it's just one person doing releases so they have a stable lockfile they intentionally update between releases, but with different people doing it we're starting from a different base each time. So I've updated the release instructions in here to point this problem out (I think the right approach is to just check in the lockfile and rely on the fact that it gets tagged on release instead of putting it in releases/). I also have a script in there that can identify the differences between releases. e.g.:
This PR hasn't had the full test runs done, I don't have that much RAM, it'd be good to get that done though to test the new dependency.