Skip to content

Add a healthcheck. #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add a healthcheck. #142

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61c65b1
Add a healthcheck.
holdenk Nov 29, 2022
2efd33d
Update Dockerfile
holdenk Dec 4, 2022
d5eef65
Move healthcheck to the nginx container not the build container
holdenk Dec 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ ARG NGINX_NAME="nginx-${NGINX_VERSION}"

FROM debian AS build

HEALTHCHECK --interval=30s --timeout=3s --start-period=60s \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@holdenk this is in the wrong place... 😸 Because this Dockerfile uses a multi-stage build, this HEALTHCHECK belongs after FROM nginx (not the FROM debian AS build where it is currently proposed).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah gotcha, yeah a halth check in the build container is probably not very useful.

CMD (curl -f http://localhost/) || exit 1

ARG NGINX_VERSION
# https://hg.nginx.org/nginx
ARG NGINX_BRANCH=default
Expand Down