Skip to content

Ensure logs are reported after 10s max #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ensure logs are reported after 10s max #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ export class Saturn {
this.onReportLogs = this.config.onReportLogs || ((_logs) => {})
this.loadNodesPromise = this.config.experimental ? this._loadNodes(this.config) : null
this.authLimiter = pLimit(1)
this.logsLastReportedAt = null
}

/**
Expand Down Expand Up @@ -469,8 +470,15 @@ export class Saturn {
reportLogs (log) {
this.logs.push(log)
if (!this.reportingLogs) return
this.reportLogsTimeout && clearTimeout(this.reportLogsTimeout)
this.reportLogsTimeout = setTimeout(this._reportLogs.bind(this), 3_000)
clearTimeout(this.reportLogsTimeout)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
clearTimeout(this.reportLogsTimeout)
this.reportLogsTimeout && clearTimeout(this.reportLogsTimeout)

this.reportLogsTimeout may be null

if (
!this.logsLastReportedAt ||
this.logsLastReportedAt.getTime() < new Date().getTime() - 10_000
) {
this._reportLogs()
} else {
this.reportLogsTimeout = setTimeout(this._reportLogs.bind(this), 3_000)
}
}

async _reportLogs () {
Expand All @@ -490,6 +498,7 @@ export class Saturn {
body: JSON.stringify({ bandwidthLogs, logSender: this.config.logSender })
}
)
this.logsLastReportedAt = new Date()
this.onReportLogs(bandwidthLogs)
} catch (e) {
console.log(e)
Expand Down