Fixed an issue where the eject drive option would sometimes show for pinned folders (#2382)

Author: yaira2

Files/UserControls/SidebarControl.xaml.cs

@@ -202,36 +202,27 @@ private void NavigationViewLocationItem_RightTapped(object sender, RightTappedRo
             Microsoft.UI.Xaml.Controls.NavigationViewItem sidebarItem = (Microsoft.UI.Xaml.Controls.NavigationViewItem)sender;
             var item = sidebarItem.DataContext as LocationItem;
 
-            if (item.IsDefaultLocation)
-            {
-                ShowUnpinItem = false;
-            }
-            else
-            {
-                ShowUnpinItem = true;
-            }
-
-            if (item.Path.Equals(App.AppSettings.RecycleBinPath, StringComparison.OrdinalIgnoreCase))
-            {
-                RecycleBinItemRightTapped?.Invoke(this, EventArgs.Empty);
-
-                ShowEmptyRecycleBin = true;
-                ShowUnpinItem = true;
-                ShowProperties = false;
-            }
-            else
-            {
-                ShowEmptyRecycleBin = false;
-                // Set to true if properties should be displayed for pinned folders
-                ShowProperties = false;
-            }
+            ShowEmptyRecycleBin = false;
+            ShowUnpinItem = true;
+            ShowProperties = true;
+            ShowEjectDevice = false;
 
-            // Additional check needed because ShowProperties is set to true if not recycle bin
             if (item.IsDefaultLocation)
             {
                 ShowProperties = false;
-            }
 
+                if (item.Path.Equals(App.AppSettings.RecycleBinPath, StringComparison.OrdinalIgnoreCase))
+                {
+                    RecycleBinItemRightTapped?.Invoke(this, EventArgs.Empty);
+
+                    ShowEmptyRecycleBin = true;
+                }
+                else
+                {
+                    ShowUnpinItem = false;
+                }
+            }
+            
             SideBarItemContextFlyout.ShowAt(sidebarItem, e.GetPosition(sidebarItem));
             App.RightClickedItem = item;
         }