Use default IDE

Author: ferrariofilippo

src/Files.App/Actions/Open/OpenInIDEAction.cs

@@ -1,6 +1,8 @@
 // Copyright (c) Files Community
 // Licensed under the MIT License.
 
+using Microsoft.UI.Xaml.Controls;
+
 namespace Files.App.Actions
 {
 	internal sealed class OpenInIDEAction : ObservableObject, IAction
@@ -31,12 +33,15 @@ public OpenInIDEAction()
 			_devToolsSettingsService.PropertyChanged += DevSettings_PropertyChanged;
 		}
 
-		public Task ExecuteAsync(object? parameter = null)
+		public async Task ExecuteAsync(object? parameter = null)
 		{
-			return Win32Helper.RunPowershellCommandAsync(
+			var res = await Win32Helper.RunPowershellCommandAsync(
 				$"& \'{_devToolsSettingsService.IDEPath}\' \'{_context.ShellPage?.ShellViewModel.WorkingDirectory}\'",
 				PowerShellExecutionOptions.Hidden
 			);
+
+			if (!res)
+				await ShowErrorDialog();
 		}
 
 		private void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)
@@ -57,5 +62,24 @@ private void DevSettings_PropertyChanged(object? sender, PropertyChangedEventArg
 				OnPropertyChanged(nameof(Description));
 			}
 		}
+
+		private async Task ShowErrorDialog()
+		{
+			var commands = Ioc.Default.GetRequiredService<ICommandManager>();
+			var errorDialog = new ContentDialog()
+			{
+				Title = Strings.IDEError.GetLocalizedResource(),
+				Content = Strings.SelectedIDENotValid.GetLocalizedResource(),
+				PrimaryButtonText = Strings.OK.GetLocalizedResource(),
+				SecondaryButtonText = Strings.EditInSettings.GetLocalizedResource(),
+			};
+
+			if (await errorDialog.TryShowAsync() == ContentDialogResult.Secondary)
+			{
+				await commands.OpenSettings.ExecuteAsync(
+					new SettingsNavigationParams() { PageKind = SettingsPageKind.DevToolsPage }
+				);
+			}
+		}
 	}
 }

src/Files.App/Actions/Open/OpenRepoInIDEAction.cs

@@ -1,8 +1,10 @@
 // Copyright (c) Files Community
 // Licensed under the MIT License.
 
+using Microsoft.UI.Xaml.Controls;
+
 namespace Files.App.Actions
-{
+{	
 	internal sealed class OpenRepoInIDEAction : ObservableObject, IAction
 	{
 		private readonly IDevToolsSettingsService _devToolsSettingsService;
@@ -28,12 +30,15 @@ public OpenRepoInIDEAction()
 			_devToolsSettingsService.PropertyChanged += DevSettings_PropertyChanged;
 		}
 
-		public Task ExecuteAsync(object? parameter = null)
+		public async Task ExecuteAsync(object? parameter = null)
 		{
-			return Win32Helper.RunPowershellCommandAsync(
+			var res = await Win32Helper.RunPowershellCommandAsync(
 				$"& \'{_devToolsSettingsService.IDEPath}\' \'{_context.ShellPage!.InstanceViewModel.GitRepositoryPath}\'",
 				PowerShellExecutionOptions.Hidden
 			);
+
+			if (!res)
+				await ShowErrorDialog();
 		}
 
 		private void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)
@@ -54,5 +59,24 @@ private void DevSettings_PropertyChanged(object? sender, PropertyChangedEventArg
 				OnPropertyChanged(nameof(Description));
 			}
 		}
+
+		private async Task ShowErrorDialog()
+		{
+			var commands = Ioc.Default.GetRequiredService<ICommandManager>();
+			var errorDialog = new ContentDialog()
+			{
+				Title = Strings.IDEError.GetLocalizedResource(),
+				Content = Strings.SelectedIDENotValid.GetLocalizedResource(),
+				PrimaryButtonText = Strings.OK.GetLocalizedResource(),
+				SecondaryButtonText = Strings.EditInSettings.GetLocalizedResource(),
+			};
+
+			if (await errorDialog.TryShowAsync() == ContentDialogResult.Secondary)
+			{
+				await commands.OpenSettings.ExecuteAsync(
+					new SettingsNavigationParams() { PageKind = SettingsPageKind.DevToolsPage }
+				);
+			}
+		}
 	}
 }

src/Files.App/Helpers/Environment/SoftwareHelpers.cs

@@ -0,0 +1,59 @@
+// Copyright (c) Files Community
+// Licensed under the MIT License.
+
+using Microsoft.Win32;
+using System.Security;
+
+namespace Files.App.Helpers
+{
+	internal static class SoftwareHelpers
+	{
+		private const string UninstallRegistryKey = @"Software\Microsoft\Windows\CurrentVersion\Uninstall";
+
+		private const string VsCodeName = "Microsoft Visual Studio Code";
+
+		public static bool IsVSCodeInstalled()
+		{
+			try
+			{
+				return
+					ContainsName(Registry.CurrentUser.OpenSubKey(UninstallRegistryKey), VsCodeName) ||
+					ContainsName(Registry.LocalMachine.OpenSubKey(UninstallRegistryKey), VsCodeName);
+			}
+			catch (SecurityException)
+			{
+				// Handle edge case where OpenSubKey results in SecurityException
+				return false;
+			}
+		}
+
+		private static bool ContainsName(RegistryKey? key, string find)
+		{
+			if (key is null)
+				return false;
+
+			try
+			{
+				foreach (var subKey in key.GetSubKeyNames().Select(key.OpenSubKey))
+				{
+					var displayName = subKey?.GetValue("DisplayName") as string;
+					if (!string.IsNullOrWhiteSpace(displayName) && displayName.StartsWith(find))
+					{
+						key.Close();
+
+						return true;
+					}
+				}
+
+				key.Close();
+
+				return false;
+			}
+			catch (SecurityException)
+			{
+				// Handle edge case where OpenSubKey results in SecurityException
+				return false;
+			}
+		}
+	}
+}

src/Files.App/Services/Settings/DevToolsSettingsService.cs

@@ -5,6 +5,8 @@ namespace Files.App.Services.Settings
 {
 	internal sealed partial class DevToolsSettingsService : BaseObservableJsonSettings, IDevToolsSettingsService
 	{
+		private bool _isVSCodeInstalled = SoftwareHelpers.IsVSCodeInstalled();
+
 		public DevToolsSettingsService(ISettingsSharingContext settingsSharingContext)
 		{
 			// Register root
@@ -21,14 +23,14 @@ public OpenInIDEOption OpenInIDEOption
 		/// <inheritdoc/>
 		public string IDEPath
 		{
-			get => Get("") ?? "";
+			get => Get(_isVSCodeInstalled ? "code" : string.Empty) ?? string.Empty;
 			set => Set(value);
 		}
 
 		/// <inheritdoc/>
 		public string FriendlyIDEName
 		{
-			get => Get("") ?? "";
+			get => Get(_isVSCodeInstalled ? Strings.VisualStudioCode.GetLocalizedResource() : string.Empty) ?? string.Empty;
 			set => Set(value);
 		}
 

src/Files.App/Strings/en-US/Resources.resw

@@ -4055,4 +4055,16 @@
   <data name="Test" xml:space="preserve">
     <value>Test</value>
   </data>
+  <data name="SelectedIDENotValid" xml:space="preserve">
+    <value>Selected IDE is not valid</value>
+  </data>
+  <data name="IDEError" xml:space="preserve">
+    <value>IDE Error</value>
+  </data>
+  <data name="EditInSettings" xml:space="preserve">
+    <value>Edit in settings</value>
+  </data>
+  <data name="VisualStudioCode" xml:space="preserve">
+    <value>Visual Studio Code</value>
+  </data>
 </root>

src/Files.App/Views/Settings/DevToolsPage.xaml

@@ -247,7 +247,7 @@
 							<Button
 								Command="{x:Bind ViewModel.SaveIDEChangesCommand, Mode=OneWay}"
 								Content="{helpers:ResourceString Name=Save}"
-								IsEnabled="{x:Bind ViewModel.CanSaveIDEChanges, Mode=OneWay}"
+								IsEnabled="{x:Bind ViewModel.CanSaveIDEChanges, Mode=OneWay, FallbackValue=False}"
 								Style="{StaticResource AccentButtonStyle}" />
 						</StackPanel>
 					</StackPanel>