Skip to content

Conversation

@yaira2
Copy link
Member

@yaira2 yaira2 commented Oct 7, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Confirmed dialog displays the type of item being created

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Oct 7, 2024
@yaira2 yaira2 requested a review from hishitetsu October 8, 2024 21:37
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Oct 9, 2024
@yaira2 yaira2 merged commit 1781b7f into main Oct 9, 2024
6 checks passed
@yaira2 yaira2 deleted the ya/CreateItem branch October 9, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Show new file/folder text in "Enter an item name" dialog

3 participants