Feature: Added an action to collapse/expand the sidebar

[Erquint]

Added a ToggleSidebar action, imitating 4af2d59 as a template.

Resolved / Related Issues

• Closes Feature: Add action to collapse & expand sidebar #16005

Steps used to test these changes

1. Launch Files.
2. Take visual note of the sidebar, its size, presentation and border.
3. Press [Ctrl]+[Alt]+[S] as the default keybinding for ToggleSidebar.
4. Observe the sidebar and note if it has either collapsed or expanded.
5. Repeat the keyboard input as in №3.
6. Observe the sidebar and note if the opposite of №4 occured.
7. Finally, repeat the input from №3 a third time to confirm that the toggle state machine survives a full loop onwards.
8. Additionally, you may try to unbind the ToggleSidebar action and rebind it to another keyboard input to repeat the test with a non-default input.
9. Could also test calling from the command palette ([Ctrl]+[Shift]+[P]).

---

Not quite seeing how I could test this myself yet. Assuming that having imitated an equivalent commit closely should make this a relatively straightforward contribution nevertheless.

As for the callback contents, it seemed like there's three ways of doing this — through:

• Ad-hoc proxy to SidebarResizer_DoubleTapped. Was my initial plan.

  • Files/src/Files.App/UserControls/Sidebar/SidebarView.xaml.cs

    Line 193 in 39df64d

    private void SidebarResizer_DoubleTapped(object sender, DoubleTappedRoutedEventArgs e)

• SidebarDisplayMode.Expanded/SidebarDisplayMode.Compact. Seemed abstracted away.

  • Files/src/Files.App/UserControls/Sidebar/SidebarDisplayMode.cs

    Line 9 in 39df64d

    public enum SidebarDisplayMode

• AppearanceSettingsService.IsSidebarOpen. Gone with this one.

  • Files/src/Files.App/ViewModels/UserControls/SidebarViewModel.cs

    Line 125 in 39df64d

    public bool IsSidebarOpen

Used the latter for this PR to closely match the reference commit.

[Erquint]

Using the 4af2d59 commit as a template betrayed me in the localization strings department, heh.
Well, it was a trivial fix — the entries already existed for this. Just needed to reference them without creating duplicates.

[Erquint]

All checks passed. Kept it a draft PR in accordance with your rules.

DO NOT submit a PR unless it the connected issue is marked as ready to build or approved indirectly by an org member. This enables us to have a discussion on the idea before anyone invests time on the implementation.

— https://github.com/files-community/Files/blob/main/.github/CONTRIBUTING.md

Once the issue is marked as ready for PR, I'll make it a PR ready for review.

[0x5bfa]

Otherwise, LGTM.
However, note that this may be rejected after all because the linked issue is still marked as planning.

[Erquint]

Thanks for the suggestion. And as for…

However, note that this may be rejected after all because the linked issue is still marked as planning.

That's why I'm keeping it a draft. 💁‍♂️

[Lamparter]

I think you misunderstood.

[yaira2]

• Press [Ctrl]+[Alt]+[S] as the default keybinding for ToggleSidebar.
• Observe the sidebar and note if it has either collapsed or expanded.

I've tried these steps, and it doesn't look like anything changes.

[Erquint]

I'll see if I can build in CLI…
Not installing MVS under any circumstances.
Is there a way to make portable builds for rapid iteration without reinstallation?

[Lamparter]

Wait, you didn't even test the changes 😬

And as for portable builds, you can download the AppxPackages archive generated from the CI pipeline.

[Erquint]

I left the PR a draft, remember?
And included testing steps.
It's a collaborative project.

I did try the workflow artifact build under a sandbox but wasn't able to have it install.
Didn't want it to mess with my existing installation, but I guess I'm gonna get rid of Files anyway, so I'll replace it with a development/test build.
But waiting on GH actions to build the binaries might not make very rapid iteration of local development.

[Lamparter]

Installing versions of Files from different production channels would not affect other channels.

[yaira2]

Didn't want it to mess with my existing installation, but I guess I'm gonna get rid of Files anyway, so I'll replace it with a development/test build.

The dev builds have a different package name so you can have both versions installed at the same time.

[yaira2]

I left the PR a draft, remember?
And included testing steps.
It's a collaborative project.

No harm done, don't worry about it 🙂

[Erquint]

Installed the artifact with Visual Studio 2022 Developer PowerShell v17.11.5 bundled with MSBuildTools.
Normal PowerShell 7.4.6 couldn't install it, because M$ broke AppX in it.

Tested the action — it doesn't work.
Thinking if SidebarResizer_DoubleTapped can be helpful here.

Files/src/Files.App/UserControls/Sidebar/SidebarView.xaml.cs

Lines 193 to 205 in 39df64d

	private void SidebarResizer_DoubleTapped(object sender, DoubleTappedRoutedEventArgs e)
	{
	if (DisplayMode == SidebarDisplayMode.Expanded)
	{
	DisplayMode = SidebarDisplayMode.Compact;
	e.Handled = true;
	}
	else
	{
	DisplayMode = SidebarDisplayMode.Expanded;
	e.Handled = true;
	}
	}

Files/src/Files.App/UserControls/Sidebar/SidebarView.xaml

Line 109 in 39df64d

DoubleTapped="SidebarResizer_DoubleTapped"

[Erquint]

Erm, no. I did something stupid. Need to refer to the instance…

P. S.

Just spotted the typo — wasn't using the interface.

[Erquint]

Wait, wasn't there an interface..? 🤔 I need rest…
Oh, it's the second instance of the same.

[Erquint]

Yeah, I'm definitely doing this wrong.

Files/src/Files.App/Actions/Show/ToggleSidebarAction.cs

Line 9 in 95c2189

private readonly ISidebarViewModel SidebarViewModel = Ioc.Default.GetRequiredService<ISidebarViewModel>();

Error: D:\a\Files\Files\src\Files.App\Actions\Show\ToggleSidebarAction.cs(9,20): error CS0246: The type or namespace name 'ISidebarViewModel' could not be found (are you missing a using directive or an assembly reference?) [D:\a\Files\Files\src\Files.App\Files.App.csproj]

Files/src/Files.App/Actions/Show/ToggleSidebarAction.cs

Line 31 in 95c2189

SidebarViewModel.UpdateTabControlMargin();

Maybe I need to expand the interface… Erm, the type isn't found… Namespace scope..?
Please advise.

[0x5bfa]

😂

[Erquint]

@0x5bfa Well, that doesn't look like advice to me.

[Lamparter]

Why wouldn't you like to install Visual Studio?
I'm sure using it would make this easier.

[yaira2]

Lets try to stay on topic

[0x5bfa]

If you want advice.

[Erquint]

Aight, let's try that.

[Erquint]

ISidebarViewModel is still out of scope, so it's the same issue still.