Skip to content

Conversation

@Lamparter
Copy link
Contributor

Resolved / Related Issues

I resolved that this was too small a change to make it worth opening an issue.

Steps used to test these changes

N/A


I noticed that the commit message for Crowdin resource sync in crowdin.yml did not match that of Files's contribution style, which requires that each commit be in the present tense and not be lower case.

yaira2
yaira2 previously approved these changes Nov 3, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Nov 3, 2024

Is there a way to auto set the PR title to "Code Quality: Updated translations"?

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Nov 3, 2024
@yaira2 yaira2 changed the title Update commit message in crowdin.yml to match contribution guidelines Code Quality: Updated commit message in crowdin.yml to match contribution guidelines Nov 3, 2024
@0x5bfa
Copy link
Member

0x5bfa commented Nov 4, 2024

As far as I know, no. This is just commit message and it's fine as is.

@Lamparter
Copy link
Contributor Author

Lamparter commented Nov 4, 2024

I'm quite sure there is, it's also possible to change the branch name (in FluentHub it's crowdin/locale).


Yes, it is! https://support.crowdin.com/developer/configuration-file/#configuration-file-for-vcs-integrations

@0x5bfa
Copy link
Member

0x5bfa commented Nov 4, 2024

WHAT I'm pretty sure there wasn't before. It's great then.

@yaira2 yaira2 merged commit 3cc1ecd into files-community:main Nov 4, 2024
6 checks passed
@Lamparter Lamparter deleted the locale branch November 4, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants