Skip to content

Conversation

@yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 4, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Confirmed the option is disabled in the root path
  2. Confirmed the feature works for single and multiple items
  3. Confirmed the menu option is only shown when the setting is enabled

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Nov 4, 2024
@yaira2 yaira2 requested a review from hishitetsu November 4, 2024 22:00
@yaira2 yaira2 requested a review from hishitetsu November 5, 2024 14:30
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 6, 2024
@yaira2
Copy link
Member Author

yaira2 commented Nov 6, 2024

@hishitetsu thank you for the review.

@yaira2 yaira2 merged commit af6207e into main Nov 6, 2024
8 checks passed
@yaira2 yaira2 deleted the ya/CreateADS branch November 6, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Create alternate data streams

3 participants