Skip to content

Code Quality: Fixed a GC hole in the network connection dialog #16482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

Code Quality: Fixed a GC hole in the network connection dialog #16482

merged 1 commit into from
Nov 18, 2024

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Nov 18, 2024

Resolved / Related Issues

  • Fixed GC hole
  • Fixed an issue where it throws an exception even though the method returns NO_ERROR (0).

Steps used to test these changes

  1. Open the connection dialog
  2. Close it

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Nov 18, 2024
@yaira2 yaira2 merged commit 76ded06 into files-community:main Nov 18, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-CmnDlgGcHole branch November 18, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0x5bfa @yaira2