Skip to content

Conversation

@yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 24, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

@yaira2 yaira2 requested a review from hishitetsu November 24, 2024 15:55
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Nov 24, 2024
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Explorer has information on the number of tabs in the window title. Should we really delete this information?

Btw, this Explorer window title in Japanese is broken lol

@0x5bfa
Copy link
Member

0x5bfa commented Nov 25, 2024

We should remove "- Files" alternatively

@yaira2
Copy link
Member Author

yaira2 commented Nov 25, 2024

Explorer has information on the number of tabs in the window title. Should we really delete this information?

I tried looking to see why we added this originally, but I didn't find any issue or feature request (this doesn't mean there wasn't one). If a valid use case is presented, I will reconsider. Otherwise, I agree with #16517 that it's cleaner without it.

@hishitetsu
Copy link
Member

I was wondering whether we should have the same display as Explorer, but I have no preference as to whether the number of tabs should be displayed.

@yaira2
Copy link
Member Author

yaira2 commented Nov 25, 2024

Notepad and Terminal don't display the number of tabs, but Microsoft Edge does. In any case, it's a minor change and we can bring it back if there is user demand.

@yaira2 yaira2 merged commit ef55240 into main Nov 25, 2024
8 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 25, 2024
@yaira2 yaira2 deleted the ya/TabCount branch November 25, 2024 14:56
@yaira2
Copy link
Member Author

yaira2 commented Nov 25, 2024

We should remove "- Files" alternatively

@0x5bfa I think it's important for the app name to always be included in the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Don't show tab count on taskbar

4 participants