Skip to content

Feature: Removed toolbar from homepage #16589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 10, 2024
Merged

Feature: Removed toolbar from homepage #16589

merged 6 commits into from
Dec 10, 2024

Conversation

@Lamparter
Copy link
Contributor

@Lamparter Lamparter commented Dec 9, 2024

Resolved / Related Issues

Steps used to test these changes

  1. Opened Files
  2. Saw toolbar is hidden

@0x5bfa
Copy link
Member

0x5bfa commented Dec 9, 2024

ShowToolbar is completely different setting here. I don't think this works when you switch between tabs.

@yaira2
Copy link
Member

yaira2 commented Dec 9, 2024

ShowToolbar is completely different setting here. I don't think this works when you switch between tabs.

This is correct

@Lamparter
Copy link
Contributor Author

Lamparter commented Dec 9, 2024 •
edited
Loading

ShowToolbar is completely different setting here. I don't think this works when you switch between tabs.

It worked when I tried it

@yaira2
Copy link
Member

yaira2 commented Dec 9, 2024

This will cause the toolbar to show even if the user turned it off from settings.

@yaira2
Copy link
Member

yaira2 commented Dec 9, 2024

@Lamparter you can do this by modifying the toolbar visibility in MainPage.xaml.

Visibility="{x:Bind converters:MultiBooleanConverter.AndConvertToVisibility(SidebarAdaptiveViewModel.PaneHolder.ActivePaneOrColumn.InstanceViewModel.IsPageTypeNotHome, ViewModel.ShowToolbar), Mode=OneWay}" />

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Dec 9, 2024
@yaira2
Copy link
Member

yaira2 commented Dec 10, 2024

Looking good! Can you please remove the header from the toolbar control now that it's no longer used?

@yaira2 yaira2 self-requested a review December 10, 2024 14:51
@Lamparter
Copy link
Contributor Author

Lamparter commented Dec 10, 2024

What do you mean?

@yaira2
Copy link
Member

yaira2 commented Dec 10, 2024

In InnerNavigationToolbar.xaml.

@yaira2 yaira2 added ready for review Pull requests that are ready for review and removed changes requested Changes are needed for this pull request labels Dec 10, 2024
yaira2
yaira2 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Dec 10, 2024
@yaira2 yaira2 merged commit be66d7c into files-community:main Dec 10, 2024
6 checks passed
@Lamparter Lamparter deleted the no-home branch December 11, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Hide toolbar when in homepage

3 participants

@Lamparter @0x5bfa @yaira2