Skip to content

Conversation

@Lamparter
Copy link
Contributor

Resolved / Related Issues

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Dec 11, 2024
Copy link
Member

@Josh65-2201 Josh65-2201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old method can be removed as both v2 and v3 use the volume folder for access. You would also need to search 1 layer sub folders for the system link. Volumes/Workspace (Normal folder)/filespace (System link) is how it's formatted.

@Josh65-2201 Josh65-2201 added the changes requested Changes are needed for this pull request label Dec 13, 2024
@yaira2 yaira2 removed the ready for review Pull requests that are ready for review label Dec 13, 2024
@Lamparter Lamparter marked this pull request as ready for review December 24, 2024 17:26
@Josh65-2201

This comment was marked as outdated.

Josh65-2201
Josh65-2201 previously approved these changes Dec 24, 2024
@Josh65-2201 Josh65-2201 added ready for review Pull requests that are ready for review and removed changes requested Changes are needed for this pull request labels Dec 24, 2024
@Lamparter Lamparter requested a review from yaira2 December 24, 2024 19:59
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private static bool IsSymlink can be removed

yaira2
yaira2 previously approved these changes Dec 24, 2024
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Dec 24, 2024
@yaira2 yaira2 merged commit 459d805 into files-community:main Dec 24, 2024
5 checks passed
@Lamparter Lamparter deleted the lucid branch December 24, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add support for Lucid Link v3+

3 participants