Skip to content

Conversation

@gave92
Copy link
Member

@gave92 gave92 commented Dec 22, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Added the same check that is present on right tapped event.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Click on empty space of column view and check the active column does not change

@gave92 gave92 changed the title Do not switch focus if pane is already active Fix: Fixed an issue causing column layout to scroll to first row when clicking Dec 22, 2024
@gave92 gave92 added the ready for review Pull requests that are ready for review label Dec 22, 2024
@yaira2 yaira2 self-requested a review December 22, 2024 01:48
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Dec 22, 2024
@yaira2 yaira2 changed the title Fix: Fixed an issue causing column layout to scroll to first row when clicking Fix: Fixed an issue causing unexpected scrolling in the Columns Layout Dec 22, 2024
@yaira2 yaira2 changed the title Fix: Fixed an issue causing unexpected scrolling in the Columns Layout Fix: Fixed an issue which caused unexpected scrolling in the Columns Layout Dec 22, 2024
@yaira2 yaira2 merged commit 71da435 into files-community:main Dec 22, 2024
6 checks passed
@gave92 gave92 deleted the issue_15776 branch December 22, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Column layout scrolls to first row when clicking

2 participants