Skip to content

Feature: Hide toggle for adaptive layout when it's not available to be used #16701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 14, 2025
Merged

Feature: Hide toggle for adaptive layout when it's not available to be used #16701

merged 6 commits into from
Jan 14, 2025

Conversation

@Lamparter
Copy link
Contributor

@Lamparter Lamparter commented Jan 12, 2025

Resolved / Related Issues

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files
  2. Looked at layout commands
  3. Button is hidden when sync layout across directories is enabled

@Lamparter Lamparter marked this pull request as ready for review January 12, 2025 16:41
yaira2
yaira2 reviewed Jan 12, 2025
View reviewed changes
@yaira2 yaira2 changed the title Feature: Hid the adaptive layout toggle when it is disabled Feature: Hide toggle for adaptive layout when it's not available Jan 12, 2025
@yaira2 yaira2 changed the title Feature: Hide toggle for adaptive layout when it's not available Feature: Hide toggle for adaptive layout when it's not available to be used Jan 12, 2025
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Jan 12, 2025
@Lamparter Lamparter requested a review from yaira2 January 14, 2025 07:32
@yaira2 yaira2 added ready for review Pull requests that are ready for review and removed changes requested Changes are needed for this pull request labels Jan 14, 2025
yaira2
yaira2 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit e8ed94d into files-community:main Jan 14, 2025
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jan 14, 2025
@Lamparter Lamparter deleted the no-adaptive-layout branch January 14, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Hide the adaptive layout toggle if it is not available

2 participants

@Lamparter @yaira2