Skip to content

Feature: Added support for rotating JPEG-XR images #16722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

Feature: Added support for rotating JPEG-XR images #16722

merged 1 commit into from
Jan 21, 2025

Conversation

@Lamparter
Copy link
Contributor

@Lamparter Lamparter commented Jan 20, 2025

Resolved / Related Issues

Steps used to test these changes

  1. Opened Files
  2. Downloaded the example JPEG-XR (.jxr) file to test:
    JXR example.zip (sorry this is in zip form because GitHub doesn't support JXR image upload directly)
  3. Tested functionality in Files, including:
    • Set as app/computer background
    • Rotate left or right

image

@Lamparter Lamparter changed the title Fix: Fixed an issue where JPEG-XR images weren't detected Fix: Fixed an issue where JPEG-XR images weren't detected as images Jan 20, 2025
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Jan 20, 2025
@yaira2 yaira2 changed the title Fix: Fixed an issue where JPEG-XR images weren't detected as images Feature: Added support for rotating JPEG-XR images Jan 20, 2025
yaira2
yaira2 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jan 21, 2025
@yaira2 yaira2 merged commit 7a562b8 into files-community:main Jan 21, 2025
6 checks passed
@Lamparter Lamparter deleted the jxr branch January 21, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Lamparter @yaira2