Skip to content

Code Quality: Update localization for recycle bin actions #16849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Code Quality: Update localization for recycle bin actions #16849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Files.App/Actions/FileSystem/EmptyRecycleBinAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ internal sealed partial class EmptyRecycleBinAction : BaseUIAction, IAction
private readonly IContentPageContext context;

public string Label
=> "EmptyRecycleBin".GetLocalizedResource();
=> Strings.EmptyRecycleBin.GetLocalizedResource();

public string Description
=> "EmptyRecycleBinDescription".GetLocalizedResource();
=> Strings.EmptyRecycleBinDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.Delete");
Expand All @@ -39,10 +39,10 @@ public async Task ExecuteAsync(object? parameter = null)
// TODO: Use AppDialogService
var confirmationDialog = new ContentDialog()
{
Title = "ConfirmEmptyBinDialogTitle".GetLocalizedResource(),
Content = "ConfirmEmptyBinDialogContent".GetLocalizedResource(),
PrimaryButtonText = "Yes".GetLocalizedResource(),
SecondaryButtonText = "Cancel".GetLocalizedResource(),
Title = Strings.ConfirmEmptyBinDialogTitle.GetLocalizedResource(),
Content = Strings.ConfirmEmptyBinDialogContent.GetLocalizedResource(),
PrimaryButtonText = Strings.Yes.GetLocalizedResource(),
SecondaryButtonText = Strings.Cancel.GetLocalizedResource(),
DefaultButton = ContentDialogButton.Primary
};

Expand Down
16 changes: 8 additions & 8 deletions src/Files.App/Actions/FileSystem/RestoreAllRecycleBinAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ internal sealed partial class RestoreAllRecycleBinAction : BaseUIAction, IAction
private readonly IStorageTrashBinService StorageTrashBinService = Ioc.Default.GetRequiredService<IStorageTrashBinService>();

public string Label
=> "RestoreAllItems".GetLocalizedResource();
=> Strings.RestoreAllItems.GetLocalizedResource();

public string Description
=> "RestoreAllRecycleBinDescription".GetLocalizedResource();
=> Strings.RestoreAllRecycleBinDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.RestoreDeleted");
Expand All @@ -28,10 +28,10 @@ public async Task ExecuteAsync(object? parameter = null)
// TODO: Use AppDialogService
var confirmationDialog = new ContentDialog()
{
Title = "ConfirmRestoreBinDialogTitle".GetLocalizedResource(),
Content = "ConfirmRestoreBinDialogContent".GetLocalizedResource(),
PrimaryButtonText = "Yes".GetLocalizedResource(),
SecondaryButtonText = "Cancel".GetLocalizedResource(),
Title = Strings.ConfirmRestoreBinDialogTitle.GetLocalizedResource(),
Content = Strings.ConfirmRestoreBinDialogContent.GetLocalizedResource(),
PrimaryButtonText = Strings.Yes.GetLocalizedResource(),
SecondaryButtonText = Strings.Cancel.GetLocalizedResource(),
DefaultButton = ContentDialogButton.Primary
};

Expand All @@ -48,8 +48,8 @@ public async Task ExecuteAsync(object? parameter = null)
{
var errorDialog = new ContentDialog()
{
Title = "FailedToRestore".GetLocalizedResource(),
PrimaryButtonText = "OK".GetLocalizedResource(),
Title = Strings.FailedToRestore.GetLocalizedResource(),
PrimaryButtonText = Strings.OK.GetLocalizedResource(),
};

if (ApiInformation.IsApiContractPresent("Windows.Foundation.UniversalApiContract", 8))
Expand Down
12 changes: 6 additions & 6 deletions src/Files.App/Actions/FileSystem/RestoreRecycleBinAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ internal sealed partial class RestoreRecycleBinAction : BaseUIAction, IAction
private readonly IContentPageContext context;

public string Label
=> "Restore".GetLocalizedResource();
=> Strings.Restore.GetLocalizedResource();

public string Description
=> "RestoreRecycleBinDescription".GetLocalizedResource();
=> Strings.RestoreRecycleBinDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.RestoreDeleted");
Expand All @@ -36,10 +36,10 @@ public async Task ExecuteAsync(object? parameter = null)
{
var confirmationDialog = new ContentDialog()
{
Title = "ConfirmRestoreSelectionBinDialogTitle".GetLocalizedResource(),
Content = string.Format("ConfirmRestoreSelectionBinDialogContent".GetLocalizedResource(), context.SelectedItems.Count),
PrimaryButtonText = "Yes".GetLocalizedResource(),
SecondaryButtonText = "Cancel".GetLocalizedResource(),
Title = Strings.ConfirmRestoreSelectionBinDialogTitle.GetLocalizedResource(),
Content = string.Format(Strings.ConfirmRestoreSelectionBinDialogContent.GetLocalizedResource(), context.SelectedItems.Count),
PrimaryButtonText = Strings.Yes.GetLocalizedResource(),
SecondaryButtonText = Strings.Cancel.GetLocalizedResource(),
DefaultButton = ContentDialogButton.Primary
};

Expand Down
Loading