Skip to content

Code Quality: Update localization strings in action classes #16879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Code Quality: Update localization strings in action classes #16879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9832706
Update localization strings in action classes
mrashutoshnigam Feb 24, 2025
9e98acc
Update localization strings in action classes
mrashutoshnigam Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Files.App/Actions/FileSystem/AddItemAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ internal sealed partial class AddItemAction : ObservableObject, IAction
private readonly AddItemDialogViewModel viewModel = new();

public string Label
=> "BaseLayoutContextFlyoutNew/Label".GetLocalizedResource();
=> Strings.BaseLayoutContextFlyoutNew_Label.GetLocalizedResource();

public string Description
=> "AddItemDescription".GetLocalizedResource();
=> Strings.AddItemDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.New.Item");
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/FileSystem/CreateFolderAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ internal sealed partial class CreateFolderAction : BaseUIAction, IAction
private readonly IContentPageContext context;

public string Label
=> "Folder".GetLocalizedResource();
=> Strings.Folder.GetLocalizedResource();

public string Description
=> "CreateFolderDescription".GetLocalizedResource();
=> Strings.CreateFolderDescription.GetLocalizedResource();

public HotKey HotKey
=> new(Keys.N, KeyModifiers.CtrlShift);
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/FileSystem/CreateFolderWithSelectionAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ internal sealed partial class CreateFolderWithSelectionAction : ObservableObject
private readonly IContentPageContext context;

public string Label
=> "CreateFolderWithSelection".GetLocalizedResource();
=> Strings.CreateFolderWithSelection.GetLocalizedResource();

public string Description
=> "CreateFolderWithSelectionDescription".GetLocalizedResource();
=> Strings.CreateFolderWithSelectionDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.New.Folder");
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/FileSystem/CreateShortcutAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ internal sealed partial class CreateShortcutAction : BaseUIAction, IAction
private readonly IContentPageContext context;

public string Label
=> "CreateShortcut".GetLocalizedResource();
=> Strings.CreateShortcut.GetLocalizedResource();

public string Description
=> "CreateShortcutDescription".GetLocalizedResource();
=> Strings.CreateShortcutDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.URL");
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/FileSystem/CreateShortcutFromDialogAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ internal sealed partial class CreateShortcutFromDialogAction : BaseUIAction, IAc
private readonly IContentPageContext context;

public string Label
=> "Shortcut".GetLocalizedResource();
=> Strings.Shortcut.GetLocalizedResource();

public string Description
=> "CreateShortcutFromDialogDescription".GetLocalizedResource();
=> Strings.CreateShortcutFromDialogDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new("\uE71B");
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/FileSystem/DeleteItemAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ namespace Files.App.Actions
internal sealed partial class DeleteItemAction : BaseDeleteAction, IAction
{
public string Label
=> "Delete".GetLocalizedResource();
=> Strings.Delete.GetLocalizedResource();

public string Description
=> "DeleteItemDescription".GetLocalizedResource();
=> Strings.DeleteItemDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new RichGlyph(themedIconStyle: "App.ThemedIcons.Delete");
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/FileSystem/DeleteItemPermanentlyAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ namespace Files.App.Actions
internal sealed partial class DeleteItemPermanentlyAction : BaseDeleteAction, IAction
{
public string Label
=> "DeletePermanently".GetLocalizedResource();
=> Strings.DeletePermanently.GetLocalizedResource();

public string Description
=> "DeleteItemPermanentlyDescription".GetLocalizedResource();
=> Strings.DeleteItemPermanentlyDescription.GetLocalizedResource();

public HotKey HotKey
=> new(Keys.Delete, KeyModifiers.Shift);
Expand Down
12 changes: 6 additions & 6 deletions src/Files.App/Actions/FileSystem/EmptyRecycleBinAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ internal sealed partial class EmptyRecycleBinAction : BaseUIAction, IAction
private readonly IContentPageContext context;

public string Label
=> "EmptyRecycleBin".GetLocalizedResource();
=> Strings.EmptyRecycleBin.GetLocalizedResource();

public string Description
=> "EmptyRecycleBinDescription".GetLocalizedResource();
=> Strings.EmptyRecycleBinDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.Delete");
Expand All @@ -39,10 +39,10 @@ public async Task ExecuteAsync(object? parameter = null)
// TODO: Use AppDialogService
var confirmationDialog = new ContentDialog()
{
Title = "ConfirmEmptyBinDialogTitle".GetLocalizedResource(),
Content = "ConfirmEmptyBinDialogContent".GetLocalizedResource(),
PrimaryButtonText = "Yes".GetLocalizedResource(),
SecondaryButtonText = "Cancel".GetLocalizedResource(),
Title = Strings.ConfirmEmptyBinDialogTitle.GetLocalizedResource(),
Content = Strings.ConfirmEmptyBinDialogContent.GetLocalizedResource(),
PrimaryButtonText = Strings.Yes.GetLocalizedResource(),
SecondaryButtonText = Strings.Cancel.GetLocalizedResource(),
DefaultButton = ContentDialogButton.Primary
};

Expand Down
12 changes: 6 additions & 6 deletions src/Files.App/Actions/FileSystem/FlattenFolderAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ internal sealed partial class FlattenFolderAction : ObservableObject, IAction
private readonly IGeneralSettingsService GeneralSettingsService = Ioc.Default.GetRequiredService<IGeneralSettingsService>();

public string Label
=> "FlattenFolder".GetLocalizedResource();
=> Strings.FlattenFolder.GetLocalizedResource();

public string Description
=> "FlattenFolderDescription".GetLocalizedResource();
=> Strings.FlattenFolderDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.Folder");
Expand Down Expand Up @@ -46,10 +46,10 @@ public async Task ExecuteAsync(object? parameter = null)

var optionsDialog = new ContentDialog()
{
Title = "FlattenFolder".GetLocalizedResource(),
Content = "FlattenFolderDialogContent".GetLocalizedResource(),
PrimaryButtonText = "Flatten".GetLocalizedResource(),
SecondaryButtonText = "Cancel".GetLocalizedResource(),
Title = Strings.FlattenFolder.GetLocalizedResource(),
Content = Strings.FlattenFolderDialogContent.GetLocalizedResource(),
PrimaryButtonText = Strings.Flatten.GetLocalizedResource(),
SecondaryButtonText = Strings.Cancel.GetLocalizedResource(),
DefaultButton = ContentDialogButton.Primary
};

Expand Down
10 changes: 5 additions & 5 deletions src/Files.App/Actions/FileSystem/OpenFileLocationAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ internal sealed partial class OpenFileLocationAction : ObservableObject, IAction
private readonly IContentPageContext context;

public string Label
=> "OpenFileLocation".GetLocalizedResource();
=> Strings.OpenFileLocation.GetLocalizedResource();

public string Description
=> "OpenFileLocationDescription".GetLocalizedResource();
=> Strings.OpenFileLocationDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(baseGlyph: "\uE8DA");
Expand Down Expand Up @@ -55,12 +55,12 @@ public async Task ExecuteAsync(object? parameter = null)
}
else if (destFolder == FileSystemStatusCode.NotFound)
{
await DialogDisplayHelper.ShowDialogAsync("FileNotFoundDialog/Title".GetLocalizedResource(), "FileNotFoundDialog/Text".GetLocalizedResource());
await DialogDisplayHelper.ShowDialogAsync(Strings.FileNotFoundDialog_Title.GetLocalizedResource(), Strings.FileNotFoundDialog_Text.GetLocalizedResource());
}
else
{
await DialogDisplayHelper.ShowDialogAsync("InvalidItemDialogTitle".GetLocalizedResource(),
string.Format("InvalidItemDialogContent".GetLocalizedResource(), Environment.NewLine, destFolder.ErrorCode.ToString()));
await DialogDisplayHelper.ShowDialogAsync(Strings.InvalidItemDialogTitle.GetLocalizedResource(),
string.Format(Strings.InvalidItemDialogContent.GetLocalizedResource(), Environment.NewLine, destFolder.ErrorCode.ToString()));
}
}

Expand Down
12 changes: 6 additions & 6 deletions src/Files.App/Actions/FileSystem/OpenItemAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ internal sealed partial class OpenItemAction : ObservableObject, IAction
private readonly IContentPageContext context;

public string Label
=> "Open".GetLocalizedResource();
=> Strings.Open.GetLocalizedResource();

public string Description
=> "OpenItemDescription".GetLocalizedResource();
=> Strings.OpenItemDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.OpenFile");
Expand Down Expand Up @@ -55,10 +55,10 @@ internal sealed partial class OpenItemWithApplicationPickerAction : ObservableOb
private readonly IContentPageContext context;

public string Label
=> "OpenWith".GetLocalizedResource();
=> Strings.OpenWith.GetLocalizedResource();

public string Description
=> "OpenItemWithApplicationPickerDescription".GetLocalizedResource();
=> Strings.OpenItemWithApplicationPickerDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.OpenWith");
Expand Down Expand Up @@ -96,10 +96,10 @@ internal sealed partial class OpenParentFolderAction : ObservableObject, IAction
private readonly IContentPageContext context;

public string Label
=> "BaseLayoutItemContextFlyoutOpenParentFolder/Text".GetLocalizedResource();
=> Strings.BaseLayoutItemContextFlyoutOpenParentFolder_Text.GetLocalizedResource();

public string Description
=> "OpenParentFolderDescription".GetLocalizedResource();
=> Strings.OpenParentFolderDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(baseGlyph: "\uE197");
Expand Down
Loading