Skip to content

Conversation

@marcofranzen99
Copy link
Contributor

Resolved / Related Issues

Steps used to test these changes
Changed theme within the app several times and opened the What's new dialog to check if the correct theme is used
image

@marcofranzen99 marcofranzen99 marked this pull request as draft March 2, 2025 21:59
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 2, 2025
@0x5bfa
Copy link
Member

0x5bfa commented Mar 3, 2025

LGTM. Enum casting is integer casting; Default to Auto is 0 to 0 so doesn't cause any issues here.

@marcofranzen99 marcofranzen99 marked this pull request as ready for review March 3, 2025 07:44
@marcofranzen99
Copy link
Contributor Author

LGTM. Enum casting is integer casting; Default to Auto is 0 to 0 so doesn't cause any issues here.

i wasn't completely sure how enum casting works, but you're right. thanks

@yaira2 yaira2 merged commit 72d812d into files-community:main Mar 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add param to website to follow app theme

3 participants