Skip to content

Code Quality: Simplified binding statements #16930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 18, 2025
Merged

Code Quality: Simplified binding statements #16930

merged 10 commits into from
Mar 18, 2025

Conversation

@Jack251970
Copy link
Contributor

@Jack251970 Jack251970 commented Mar 14, 2025 •
edited
Loading

Resolved / Related Issues

  • Improve code quality for binding statement. See details in each commit.
  • Closes #

Steps used to test these changes

  1. Open Files to check navigation tool bar and info panel control.

@Jack251970 Jack251970 changed the title Code Quality: General Code Quality Code Quality: Improve General Code Quality Mar 14, 2025
0x5bfa
0x5bfa suggested changes Mar 14, 2025
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Yair accepts this PR.

0x5bfa
0x5bfa approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Lamparter
Lamparter approved these changes Mar 15, 2025
View reviewed changes
Copy link
Contributor

@Lamparter Lamparter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rename the PR to something else a little bit less generic, such as Code Quality: Simplified binding statements

@Jack251970 Jack251970 changed the title Code Quality: Improve General Code Quality Code Quality: Simplified binding statements Mar 15, 2025
@Jack251970
Copy link
Contributor Author

Jack251970 commented Mar 15, 2025

I'd rename the PR to something else a little bit less generic, such as Code Quality: Simplified binding statements

get it

yaira2
yaira2 reviewed Mar 16, 2025
View reviewed changes
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Mar 16, 2025
yaira2
yaira2 reviewed Mar 16, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 16, 2025
View reviewed changes
@yaira2
Copy link
Member

yaira2 commented Mar 16, 2025

@Jack251970 when you have a chance, can you please fill out the PR template? Thank you 🙂

@Jack251970 Jack251970 force-pushed the general_code_quality_fix branch from 790b0c9 to c41ebc0 Compare March 16, 2025 16:10
@Jack251970
Copy link
Contributor Author

Jack251970 commented Mar 16, 2025 •
edited
Loading

@Jack251970 when you have a chance, can you please fill out the PR template? Thank you 🙂

I will do it.

Could you please help me resolve the conflicts? I tried to do it but it will cause indention issue on my device (and I force-pushed to revert them😢). Thanks!

@yaira2 yaira2 force-pushed the general_code_quality_fix branch from c41ebc0 to 59578de Compare March 16, 2025 20:26
@yaira2
Copy link
Member

yaira2 commented Mar 16, 2025

@Jack251970 I rebased your branch from main, you may have to delete your local branch and pull from the remote as the commit order has been updated.

yaira2
yaira2 reviewed Mar 16, 2025
View reviewed changes
@yaira2 yaira2 added ready for review Pull requests that are ready for review and removed changes requested Changes are needed for this pull request labels Mar 16, 2025
@Jack251970 Jack251970 requested a review from yaira2 March 17, 2025 01:01
0x5bfa
0x5bfa approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

yaira2
yaira2 reviewed Mar 18, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 18, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 18, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 18, 2025
View reviewed changes
@Jack251970 Jack251970 requested a review from yaira2 March 18, 2025 14:41
yaira2
yaira2 approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Mar 18, 2025
@yaira2 yaira2 merged commit 38701a9 into files-community:main Mar 18, 2025
6 checks passed
@0x5bfa 0x5bfa mentioned this pull request Mar 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

+2 more reviewers

@0x5bfa 0x5bfa 0x5bfa approved these changes

@Lamparter Lamparter Lamparter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jack251970 @yaira2 @0x5bfa @Lamparter